[jira] [Created] (SPARK-17635) Remove hardcode "agg_plan" in HashAggregateExec

["yucai (JIRA)" <ji...@apache.org>]

yucai created SPARK-17635:
-----------------------------

             Summary: Remove hardcode "agg_plan" in HashAggregateExec
                 Key: SPARK-17635
                 URL: https://issues.apache.org/jira/browse/SPARK-17635
             Project: Spark
          Issue Type: Bug
          Components: SQL
    Affects Versions: 2.0.0
            Reporter: yucai


"agg_plan" is hardcoded in HashAggregateExec, which has potential issue.
{code}
        ctx.addMutableState(fastHashMapClassName, fastHashMapTerm,
          s"$fastHashMapTerm = new $fastHashMapClassName(" +
            s"agg_plan.getTaskMemoryManager(), agg_plan.getEmptyAggregationBuffer());")
{code}

I faced this issue when I work on sort agg's codegen support. Below codes will trigger bug:
{code}
  private def variablePrefix: String = this match {
 -    case _: HashAggregateExec => "agg"		 
 +    case _: HashAggregateExec => "hagg"
 +    case _: SortAggregateExec => "sagg"
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org