You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/08/20 19:30:13 UTC
[kudu-CR] [test] Use valid tablet ids in tests
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11272
Change subject: [test] Use valid tablet ids in tests
......................................................................
[test] Use valid tablet ids in tests
Some tests used tablet ids that were not valid
Kudu object ids. This patch changes them to
use a valid id in preperaption for a follow on
patch which makes tablet id validation more strict.
Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
4 files changed, 37 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/11272/1
--
To view, visit http://gerrit.cloudera.org:8080/11272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Gerrit-Change-Number: 11272
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [test] Use valid tablet ids in tests
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11272 )
Change subject: [test] Use valid tablet ids in tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Gerrit-Change-Number: 11272
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 22:27:28 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Use valid tablet ids in tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11272 )
Change subject: [test] Use valid tablet ids in tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Gerrit-Change-Number: 11272
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:32:25 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Use valid tablet ids in tests
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11272 )
Change subject: [test] Use valid tablet ids in tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Gerrit-Change-Number: 11272
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:43:37 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Use valid tablet ids in tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11272 )
Change subject: [test] Use valid tablet ids in tests
......................................................................
[test] Use valid tablet ids in tests
Some tests used tablet ids that were not valid
Kudu object ids. This patch changes them to
use a valid id in preperaption for a follow on
patch which makes tablet id validation more strict.
Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Reviewed-on: http://gerrit.cloudera.org:8080/11272
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
4 files changed, 37 insertions(+), 35 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Andrew Wong: Looks good to me, approved
Attila Bukor: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83d774abf2cb2ce6f81d1f851f2cc1ddd12e1726
Gerrit-Change-Number: 11272
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins