You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/20 11:32:49 UTC

[GitHub] [kafka] cadonna commented on a change in pull request #8514: MINOR: Further reduce runtime for metrics integration tests

cadonna commented on a change in pull request #8514:
URL: https://github.com/apache/kafka/pull/8514#discussion_r411304452



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
##########
@@ -319,18 +266,6 @@ private void checkMetricByName(final List<Metric> listMetric,
         }
     }
 
-    private void verifyThatBytesWrittenTotalIncreases(final KafkaStreams kafkaStreams,
-                                                      final String metricsScope) throws InterruptedException {
-        final List<Metric> metric = getRocksDBMetrics(kafkaStreams, metricsScope).stream()
-            .filter(m -> BYTES_WRITTEN_TOTAL.equals(m.metricName().name()))
-            .collect(Collectors.toList());
-        TestUtils.waitForCondition(
-            () -> (double) metric.get(0).metricValue() > 0,
-            TIMEOUT,
-            () -> "RocksDB metric bytes.written.total did not increase in " + TIMEOUT + " ms"
-        );
-    }
-

Review comment:
       Thank you! I forgot to delete this in my refctoring.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org