[jira] [Commented] (MAPREDUCE-5640) Rename TestLineRecordReader in jobclient module

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829207#comment-13829207 ] 

Hadoop QA commented on MAPREDUCE-5640:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12615146/MAPREDUCE-5640.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.mapred.TestJobCleanup

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4223//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4223//console

This message is automatically generated.

> Rename TestLineRecordReader in jobclient module
> -----------------------------------------------
>
>                 Key: MAPREDUCE-5640
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5640
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.9, 2.2.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Trivial
>         Attachments: MAPREDUCE-5640.patch
>
>
> HADOOP-9622 proposes to add new unit tests for LineRecordReader in the mapreduce-client-core module alongside the code.  The existing LineRecordReader tests in the mapreduce-client-jobclient module should be renamed to something like TestLineRecordReaderJobs to avoid a name conflict and to better indicate these are integration tests using full jobs rather than unit tests.



--
This message was sent by Atlassian JIRA
(v6.1#6144)