You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/22 11:07:28 UTC
[GitHub] [flink] imaffe opened a new pull request, #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector
imaffe opened a new pull request, #20886:
URL: https://github.com/apache/flink/pull/20886
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
Yes this PR involves documentation
## Some notes
Here are some thought about this PR. any suggestions are greatly welcomed and it would be nice to have your thoughts~
- Currently this PR does not involve documentation. we want to create a different PR for SQL Connector documentation. WDYT ?
- The e2e test (SQL client e2e test) is not present in this PR as well. This is because we didn't have the SQL Client e2e test in our fork, and since it's new code, we want to create a new PR for e2e
- The naming of commits does not have a JIRA ticket to track. This is because I want to keep each commit as independent as possible during review process. Ideally we will rebase these commits and add JIRA number later.
There are 16 commits numbered from a to p ( I don't know why I didn't use numbers XD, a rush a blood to the head probably). I tried to make the commits as independent as possible.
- a to c: SQL Connector code
- d to g: Testing code
- h: packaging and manifest change. I am not sure if this part is correct because we did some hack on the pom when we were maintaining our own fork. Your input is important here ~
- i: doc and doc generation configs
- j to o: support SQL Connector involves some changes in the DataStream connector code base as well. I prefixed such commits with "DataStream"
Other commits are checkstyle or some later changes. For later fixing commits (after review), I'll use number plus the letter to track which commits the fixing points to .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20886:
URL: https://github.com/apache/flink/pull/20886#issuecomment-1330956114
With https://github.com/apache/flink-connector-pulsar/pull/1 getting close to get merged, let's not merge this PR but:
1. Wait for the mentioned PR to be merged
2. We'll release the Pulsar connector 3.0.0, which is the equivalent of the `release-1.16` version.
3. We'll update the Pulsar connector with whatever changes that exist in `master` but haven't been externalised yet.
4. Move this PR (and other Pulsar PRs) to the external connector repository so we can separately from the Flink release, release a new version of the Flink connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector
URL: https://github.com/apache/flink/pull/20886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20886:
URL: https://github.com/apache/flink/pull/20886#issuecomment-1254886525
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "530ed1716cbcec07a34e728f86ed9154428ce8f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "530ed1716cbcec07a34e728f86ed9154428ce8f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 530ed1716cbcec07a34e728f86ed9154428ce8f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20886:
URL: https://github.com/apache/flink/pull/20886#issuecomment-2768303914
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] syhily commented on pull request #20886: [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector
Posted by GitBox <gi...@apache.org>.
syhily commented on PR #20886:
URL: https://github.com/apache/flink/pull/20886#issuecomment-1255857702
Thanks for your contribution. I'll review this ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26203][Connectors / Pulsar][docs] Introduce Flink Pulsar SQL Connector [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20886:
URL: https://github.com/apache/flink/pull/20886#issuecomment-2592603157
This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out to the
[community](https://flink.apache.org/what-is-flink/community/).
<p>
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 90 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org