[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6789: Nessie: Use latest hash for catalog APIs

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#discussion_r1138149788


##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -60,6 +60,8 @@ public String getHash() {
     return reference.getHash();
   }
 
+  /** @deprecated will be removed in 1.3.0 */
+  @Deprecated
   public Branch getAsBranch() {

Review Comment:
   because all the places where this was called, already there is a check for `getRef().checkMutable()`.  So, no need for one more method calls that check if it is a branch. Hence, directly casting to branch. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org