[GitHub] [pulsar] 315157973 commented on a change in pull request #7193: function to read compacted topics

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #7193:
URL: https://github.com/apache/pulsar/pull/7193#discussion_r438584451



##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -94,6 +94,7 @@ message ConsumerSpec {
         int32 value = 1;
     }
     ReceiverQueueSize receiverQueueSize = 4;
+    bool readCompacted = 5;

Review comment:
       > We already have a ConsumerConfig class:
   > 
   > https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/functions/ConsumerConfig.java
   > 
   > Though I am for refactoring this to be generic Map so we don't have to make code changes for new consumer configs that are added.
   
   Thanks very much. But schemaProperties are properties belonging to the schema. Put the Consumer parameters with them, I don’t think it’s a good way. I think it is necessary to add a new Map to save the general parameters of Consumer.And this make it easier to convert Map to object




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org