You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by dp...@apache.org on 2020/07/30 05:11:48 UTC

[cordova-cli] branch master updated: test: fix node.js version check

This is an automated email from the ASF dual-hosted git repository.

dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new ecf89b6  test: fix node.js version check
ecf89b6 is described below

commit ecf89b6581aa6ef944c3785f9d2528b042f72266
Author: Erisu <el...@gmail.com>
AuthorDate: Thu Jul 30 12:59:56 2020 +0900

    test: fix node.js version check
---
 spec/cli.spec.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index 051054f..2edafcb 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -493,8 +493,8 @@ describe('cordova cli', () => {
             cli.__set__('NODE_VERSION_REQUIREMENT', '>=8');
 
             return cli(['node', 'cordova']).then(() => {
-                const errorMsg = logger.warn.calls.argsFor(1).toString();
-                expect(errorMsg).toMatch(/v6.1.0 is no longer supported./);
+                const errorMsg = logger.warn.calls.allArgs().toString();
+                expect(errorMsg).toMatch(/Node.js v6.1.0 is no longer supported./);
             });
         });
 
@@ -504,8 +504,8 @@ describe('cordova cli', () => {
             cli.__set__('NODE_VERSION_REQUIREMENT', '>=8');
 
             return cli(['node', 'cordova']).then(() => {
-                const errorMsg = logger.warn.calls.argsFor(1).toString();
-                expect(errorMsg).toBeFalsy();
+                const errorMsg = logger.warn.calls.allArgs().toString();
+                expect(errorMsg).not.toMatch(/Node.js v6.1.0 is no longer supported./);
             });
         });
 
@@ -515,8 +515,8 @@ describe('cordova cli', () => {
             cli.__set__('NODE_VERSION_REQUIREMENT', '>=8');
 
             return cli(['node', 'cordova']).then(() => {
-                const errorMsg = logger.warn.calls.argsFor(1).toString();
-                expect(errorMsg).toMatch(/v8.0.0 has been deprecated./);
+                const errorMsg = logger.warn.calls.allArgs().toString();
+                expect(errorMsg).toMatch(/Node.js v8.0.0 has been deprecated./);
             });
         });
 
@@ -526,8 +526,8 @@ describe('cordova cli', () => {
             cli.__set__('NODE_VERSION_REQUIREMENT', '>=8');
 
             return cli(['node', 'cordova']).then(() => {
-                const errorMsg = logger.warn.calls.argsFor(1).toString();
-                expect(errorMsg).toBeFalsy();
+                const errorMsg = logger.warn.calls.allArgs().toString();
+                expect(errorMsg).not.toMatch(/Node.js v8.0.0 has been deprecated./);
             });
         });
     });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org