You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/22 05:16:33 UTC
Review Request 17171: Improved Group to take label as an option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17171/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
This updates the "Group" to create znodes with a label.
This is part1 for MESOS-903.
Diffs
-----
src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89
src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9
src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c
Diff: https://reviews.apache.org/r/17171/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17171: Improved Group to take label as an option.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17171/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 11:36 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
benh's. NNFR.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
This updates the "Group" to create znodes with a label.
This is part1 for MESOS-903.
Diffs (updated)
-----
src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89
src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9
src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c
Diff: https://reviews.apache.org/r/17171/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17171: Improved Group to take label as an option.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17171/#review32568
-----------------------------------------------------------
Ship it!
src/zookeeper/group.hpp
<https://reviews.apache.org/r/17171/#comment61463>
In retrospect (after this diff), I think something like zkBasename would be better. :/
src/zookeeper/group.cpp
<https://reviews.apache.org/r/17171/#comment61462>
Indent of +2 or +4?
src/zookeeper/zookeeper.hpp
<https://reviews.apache.org/r/17171/#comment61461>
Indentation! ;)
src/zookeeper/zookeeper.hpp
<https://reviews.apache.org/r/17171/#comment61460>
Indentation! ;)
- Benjamin Hindman
On Jan. 22, 2014, 10:18 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17171/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 10:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-903
> https://issues.apache.org/jira/browse/MESOS-903
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This updates the "Group" to create znodes with a label.
>
> This is part1 for MESOS-903.
>
>
> Diffs
> -----
>
> src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89
> src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
> src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9
> src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c
>
> Diff: https://reviews.apache.org/r/17171/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17171: Improved Group to take label as an option.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17171/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 10:18 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
Changes
-------
benh's. NNFR.
Bugs: MESOS-903
https://issues.apache.org/jira/browse/MESOS-903
Repository: mesos-git
Description
-------
This updates the "Group" to create znodes with a label.
This is part1 for MESOS-903.
Diffs (updated)
-----
src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89
src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9
src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c
Diff: https://reviews.apache.org/r/17171/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17171: Improved Group to take label as an option.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17171/#review32500
-----------------------------------------------------------
Ship it!
Sweet!
src/zookeeper/group.hpp
<https://reviews.apache.org/r/17171/#comment61361>
Let's make this a static member of GroupProcess (which still has friend access to Membership) with a signature like 'std::string GroupProcess::znode(const Group::Membership& membership)' so that we can keep the implementation details private.
src/zookeeper/zookeeper.hpp
<https://reviews.apache.org/r/17171/#comment61359>
Please fix indentation.
src/zookeeper/zookeeper.hpp
<https://reviews.apache.org/r/17171/#comment61360>
Please fix indentation.
- Benjamin Hindman
On Jan. 22, 2014, 4:16 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17171/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 4:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Jiang Yan Xu.
>
>
> Bugs: MESOS-903
> https://issues.apache.org/jira/browse/MESOS-903
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This updates the "Group" to create znodes with a label.
>
> This is part1 for MESOS-903.
>
>
> Diffs
> -----
>
> src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89
> src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66
> src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9
> src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c
>
> Diff: https://reviews.apache.org/r/17171/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>