[GitHub] [airflow] potiuk commented on issue #19967: Breeze: Setup Autocomplete for Breeze

[GitBox <gi...@apache.org>]

potiuk commented on issue #19967:
URL: https://github.com/apache/airflow/issues/19967#issuecomment-986907614


   @uranusjr is right - Click completion is the right approach. And I aggre that the scripts should be automatically generated by .pre-commit.
   
   > So when someone adds a new command, they can be automatically reminded to regenerate the autocompletion script.
   
   Not even reminded - the scripts should be automatically regenerated. We have quite a few of those already - for example look here: https://github.com/apache/airflow/blob/cc3f038aede71d54e66cce37fe5ce1d4ec5a86e4/.pre-commit-config.yaml#L355 where we take a version and update it in a few places. 
   
   In this case as pre-commit we should simply run generation of the scrits whenever the dev/breeze/src/airflow_breeze.py changes.
   
   See how to generate the scripts here: https://click.palletsprojects.com/en/7.x/bashcomplete/#activation-script 
   
   Then I think we coud make (or find) the right way to update .zshrc/.bashrc etc with those activation commands (I guess someone had done that). 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org