[GitHub] [incubator-seatunnel] laglangyue commented on a diff in pull request #2776: [connector-v1][doc]Fix inconsistency between document and code logic

[GitBox <gi...@apache.org>]

laglangyue commented on code in PR #2776:
URL: https://github.com/apache/incubator-seatunnel/pull/2776#discussion_r973712604


##########
docs/en/connector/sink/Jdbc.mdx:
##########
@@ -75,9 +75,9 @@ The transaction isolation level, which applies to current connection. The defaul
 ### customUpdateStmt [string]
 
 Configure when `saveMode` is specified as `update` , which is used to specify the update statement template for key conflicts
-
-Refer to the usage of `INSERT INTO table (...) values (...) ON DUPLICATE KEY UPDATE... ` of `mysql` , use placeholders or fixed values in `values`
-
+if `customUpdateStmt` is empty ,the sql will auto-generate for all columns, else use your sql which refer to the usage of
+`INSERT INTO table (...) values (...) ON DUPLICATE KEY UPDATE... ` of `mysql` , use placeholders or fixed values in `values`
+tips: the tableName of sql should be consistent with the dbName.

Review Comment:
   ![image](https://user-images.githubusercontent.com/35491928/190901422-ce94c0c8-899a-45e6-b0fd-13ed8a04b00f.png)
   
   1. In many scenarios, do not need to customize the updateSQL, which can be generated automatically. In addition, user-defined sql is prone to exceptions that the number of parameters does not match.
   
   2. If need customize SQL exactly, the table name of SQL should be consistent with that of dbTable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org