You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/22 13:09:06 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1454: IGNITE-18418: Create ignite-jdbc module

korlov42 commented on code in PR #1454:
URL: https://github.com/apache/ignite-3/pull/1454#discussion_r1055435297


##########
modules/jdbc/src/main/java/org/apache/ignite/jdbc/JdbcPreparedStatement.java:
##########
@@ -107,7 +106,7 @@ public int[] executeBatch() throws SQLException {
 
         closeResults();
 
-        if (CollectionUtils.nullOrEmpty(batchedArgs) || StringUtil.isNullOrEmpty(sql)) {
+        if (CollectionUtils.nullOrEmpty(batchedArgs) || (sql == null || sql.isBlank())) {

Review Comment:
   Perhaps, it would be better to reuse `org.apache.ignite.internal.util.StringUtils#nullOrBlank` from core module



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org