You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/09 18:18:42 UTC

[GitHub] [nifi] jfrazee edited a comment on pull request #4814: NIFI-8215: --wait-for-init feature in nifi.sh refactored

jfrazee edited a comment on pull request #4814:
URL: https://github.com/apache/nifi/pull/4814#issuecomment-776138163


   @pgyori I should have mentioned this since I saw it yesterday, but this doesn't apply the `--wait-for-init` to `restart` since the `$@` isn't provided to the `start`. The naive change would be this:
   
   ```sh
   restart)
       init                                                                                           
       shift
       run "stop"             
       run "start" "$@"
       ;;
   ```
   
   I'm not 100% sure whether that's correct though because in `run()` there's some use of `$1` and the `shift` changes `$@`. Should we change this now, or do it later?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org