You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/13 08:05:41 UTC
[GitHub] [flink] libenchao opened a new pull request #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
libenchao opened a new pull request #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Change JsonRowSerializationSchema's constructor private, and force to use Builder to build JsonRowSerializationSchema.
## Brief change log
- JsonRowSerializationSchema's constructor private
- Add static builder method for JsonRowSerializationSchema
- deprecate JsonRowSerializationSchema.Builder's public constructor
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149304101 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
* 4d421fec466c39ff97ac208eade8b4f32851cf21 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149304101) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #11080: [FLINK-15988][json]
Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
* 4d421fec466c39ff97ac208eade8b4f32851cf21 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#discussion_r380085712
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
##########
@@ -99,35 +94,66 @@ public JsonRowSerializationSchema(TypeInformation<Row> typeInfo) {
@PublicEvolving
public static class Builder {
- private final RowTypeInfo typeInfo;
+ private RowTypeInfo typeInfo;
+
+ private Builder() {
+ // private constructor
+ }
/**
+ * @deprecated Use {@link JsonRowSerializationSchema#builder()} instead.
+ *
* Creates a JSON serialization schema for the given type information.
*
* @param typeInfo Type information describing the result type. The field names of {@link Row}
* are used to parse the JSON properties.
*/
+ @Deprecated
public Builder(TypeInformation<Row> typeInfo) {
checkArgument(typeInfo instanceof RowTypeInfo, "Only RowTypeInfo is supported");
this.typeInfo = (RowTypeInfo) typeInfo;
}
/**
+ * @deprecated Use {@link JsonRowSerializationSchema#builder()} instead.
+ *
* Creates a JSON serialization schema for the given JSON schema.
*
* @param jsonSchema JSON schema describing the result type
*
* @see <a href="http://json-schema.org/">http://json-schema.org/</a>
*/
+ @Deprecated
public Builder(String jsonSchema) {
this(JsonRowSchemaConverter.convert(checkNotNull(jsonSchema)));
}
+ /**
+ * Sets type information for JSON serialization schema.
+ *
+ * @param typeInfo Type information describing the result type. The field names of {@link Row}
+ * are used to parse the JSON properties.
+ */
+ public Builder withTypeInfo(TypeInformation<Row> typeInfo) {
+ checkArgument(typeInfo instanceof RowTypeInfo, "Only RowTypeInfo is supported");
+ this.typeInfo = (RowTypeInfo) typeInfo;
+ return this;
+ }
+
+ /**
+ * Finalizes the configuration and checks validity.
+ * @return Configured {@link JsonRowSerializationSchema}
+ */
public JsonRowSerializationSchema build() {
+ checkArgument(typeInfo != null, "typeInfo should be set.");
return new JsonRowSerializationSchema(typeInfo);
}
}
+ public static Builder builder() {
Review comment:
Add a javadoc on this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149304101 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
* 4d421fec466c39ff97ac208eade8b4f32851cf21 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149304101) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11080: [FLINK-15988][json]
Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11080: [FLINK-15988][json]
Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-587041431
@wuchong fixed check style problem. will do the check before pushing code to github next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585612191
<!--
Meta data
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148745731 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:8bed2dbf577c649ad3e6b411730763c90a898a5d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126 TriggerType:PUSH TriggerID:8bed2dbf577c649ad3e6b411730763c90a898a5d
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149261471 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:75ca630c234f01097ac97ccb2257e532490dae51 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242 TriggerType:PUSH TriggerID:75ca630c234f01097ac97ccb2257e532490dae51
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149304101 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
Hash:4d421fec466c39ff97ac208eade8b4f32851cf21 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255 TriggerType:PUSH TriggerID:4d421fec466c39ff97ac208eade8b4f32851cf21
-->
## CI report:
* 8bed2dbf577c649ad3e6b411730763c90a898a5d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148745731) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5126)
* 75ca630c234f01097ac97ccb2257e532490dae51 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149261471) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5242)
* 4d421fec466c39ff97ac208eade8b4f32851cf21 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149304101) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5255)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#discussion_r380085386
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
##########
@@ -99,35 +94,66 @@ public JsonRowSerializationSchema(TypeInformation<Row> typeInfo) {
@PublicEvolving
public static class Builder {
- private final RowTypeInfo typeInfo;
+ private RowTypeInfo typeInfo;
+
+ private Builder() {
+ // private constructor
+ }
/**
+ * @deprecated Use {@link JsonRowSerializationSchema#builder()} instead.
Review comment:
Put the `@deprecated` comment after `@param`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11080: [FLINK-15988][json]
Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-586930344
@wuchong Thanks for your review, I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #11080: [FLINK-15988][json] Make
JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-587026634
The compile is failed, please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11080: [FLINK-15988][json]
Make JsonRowSerializationSchema's constructor private
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#issuecomment-585602270
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8bed2dbf577c649ad3e6b411730763c90a898a5d (Thu Feb 13 08:07:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services