You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/14 01:49:39 UTC

[GitHub] [apisix] nic-6443 commented on issue #6301: bug: some mistakes in prometheus plugin

nic-6443 commented on issue #6301:
URL: https://github.com/apache/apisix/issues/6301#issuecomment-1038542214


   > Yes, it is good.
   > 
   > > nginx_http_requests_total
   > 
   > Do you mean `apisix_http_requests_total`?
   
   I think it's OK to use `apisix` as a prefix, but the previous metric used `nginx` as a prefix, do you think it needs to be changed together?
   https://github.com/apache/apisix/blob/0920d1d21fba36947b4ce13438040874c5d37610/apisix/plugins/prometheus/exporter.lua#L86-L88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org