You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/10/16 11:04:13 UTC
svn commit: r1904610 - in /pdfbox/branches/2.0: fontbox/src/main/java/org/apache/fontbox/cff/ pdfbox/src/main/java/org/apache/pdfbox/multipdf/ pdfbox/src/main/java/org/apache/pdfbox/pdmodel/ pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/ tools/src...
Author: tilman
Date: Sun Oct 16 11:04:13 2022
New Revision: 1904610
URL: http://svn.apache.org/viewvc?rev=1904610&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov
Modified:
pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java
pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java
Modified: pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java (original)
+++ pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java Sun Oct 16 11:04:13 2022
@@ -365,7 +365,7 @@ public class CFFParser
exponentMissing = false;
break;
case 0xa:
- sb.append(".");
+ sb.append('.');
break;
case 0xb:
if (hasExponent)
@@ -373,7 +373,7 @@ public class CFFParser
LOG.warn("duplicate 'E' ignored after " + sb);
break;
}
- sb.append("E");
+ sb.append('E');
exponentMissing = true;
hasExponent = true;
break;
@@ -390,7 +390,7 @@ public class CFFParser
case 0xd:
break;
case 0xe:
- sb.append("-");
+ sb.append('-');
break;
case 0xf:
done = true;
@@ -406,7 +406,7 @@ public class CFFParser
// the exponent is missing, just append "0" to avoid an exception
// not sure if 0 is the correct value, but it seems to fit
// see PDFBOX-1522
- sb.append("0");
+ sb.append('0');
}
if (sb.length() == 0)
{
Modified: pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java (original)
+++ pdfbox/branches/2.0/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java Sun Oct 16 11:04:13 2022
@@ -43,7 +43,7 @@ public final class Type1FontUtil
String string = Integer.toHexString(aByte & 0xff);
if (string.length() == 1)
{
- sb.append("0");
+ sb.append('0');
}
sb.append(string.toUpperCase(Locale.US));
}
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java Sun Oct 16 11:04:13 2022
@@ -541,7 +541,7 @@ public class Overlay implements Closeabl
for (double v : flatmatrix)
{
overlayStream.append(float2String((float) v));
- overlayStream.append(" ");
+ overlayStream.append(' ');
}
overlayStream.append(" cm\n");
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java Sun Oct 16 11:04:13 2022
@@ -455,20 +455,20 @@ abstract class PDAbstractContentStream i
sb.append(inlineImage.getHeight());
sb.append("\n /CS ");
- sb.append("/");
+ sb.append('/');
sb.append(inlineImage.getColorSpace().getName());
COSArray decodeArray = inlineImage.getDecode();
if (decodeArray != null && decodeArray.size() > 0)
{
sb.append("\n /D ");
- sb.append("[");
+ sb.append('[');
for (COSBase base : decodeArray)
{
sb.append(((COSNumber) base).intValue());
- sb.append(" ");
+ sb.append(' ');
}
- sb.append("]");
+ sb.append(']');
}
if (inlineImage.isStencil())
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageContentStream.java Sun Oct 16 11:04:13 2022
@@ -834,20 +834,20 @@ public final class PDPageContentStream i
sb.append(inlineImage.getHeight());
sb.append("\n /CS ");
- sb.append("/");
+ sb.append('/');
sb.append(inlineImage.getColorSpace().getName());
COSArray decodeArray = inlineImage.getDecode();
if (decodeArray != null && decodeArray.size() > 0)
{
sb.append("\n /D ");
- sb.append("[");
+ sb.append('[');
for (COSBase base : decodeArray)
{
sb.append(((COSNumber) base).intValue());
- sb.append(" ");
+ sb.append(' ');
}
- sb.append("]");
+ sb.append(']');
}
if (inlineImage.isStencil())
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFField.java Sun Oct 16 11:04:13 2022
@@ -820,7 +820,7 @@ public class FDFField implements COSObje
default:
if (c > 0x7e)
{
- escapedXML.append("&#").append((int) c).append(";");
+ escapedXML.append("&#").append((int) c).append(';');
}
else
{
Modified: pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java (original)
+++ pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java Sun Oct 16 11:04:13 2022
@@ -233,7 +233,7 @@ public class PDFText2HTML extends PDFTex
// write non-ASCII as named entities
if ((character < 32) || (character > 126))
{
- builder.append("&#").append((int) character).append(";");
+ builder.append("&#").append((int) character).append(';');
}
else
{
Modified: pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java?rev=1904610&r1=1904609&r2=1904610&view=diff
==============================================================================
--- pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java (original)
+++ pdfbox/branches/2.0/tools/src/main/java/org/apache/pdfbox/tools/TextToPDF.java Sun Oct 16 11:04:13 2022
@@ -169,7 +169,7 @@ public class TextToPDF
{
if (addSpace)
{
- nextLineToDraw.append(" ");
+ nextLineToDraw.append(' ');
}
else
{