[jira] [Commented] (CALCITE-3219) Allow finer control over which expressions get expanded in SqlToRelConverter

["Pressenna (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907211#comment-16907211 ] 

Pressenna commented on CALCITE-3219:
------------------------------------

created https://github.com/apache/calcite/pull/1378 for the changes, which I would use as a discussion basis.

> Allow finer control over which expressions get expanded in SqlToRelConverter
> ----------------------------------------------------------------------------
>
>                 Key: CALCITE-3219
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3219
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Pressenna
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently one can control if sub-query expansion happens via SqlToRelConverter.Config.isExpand(). This flag is global to the query and causes expansion of all supported expression types. For some systems it is required that one can dynamically narrow the set of expressions that should be expanded.
> In order to allow this, I would propose a new setter with a default implementation that returns the above flag.
> {code}
> // a BiPredicate in order to pass both the original query and the expression in question for expansion
> java.util.function.BiPredicate<SqlNode, SqlNode> SqlToRelConverter.Config.getExpandPredicate()
> {code}
> If this is OK, I would provide a PR with the relevant changes.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)