[GitHub] [arrow] nevi-me commented on a change in pull request #8204: ARROW-10016: [Rust] Implement is null / is not null kernels

[GitBox <gi...@apache.org>]

nevi-me commented on a change in pull request #8204:
URL: https://github.com/apache/arrow/pull/8204#discussion_r490853034



##########
File path: rust/arrow/src/compute/kernels/boolean.rs
##########
@@ -123,9 +125,78 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray> {
     Ok(BooleanArray::from(Arc::new(data)))
 }
 
+pub fn is_null(input: &ArrayRef) -> Result<BooleanArray> {
+    if input.offset() % 8 != 0 {

Review comment:
       Is this limitation fine, or is there a potential way around it? Does it mean that `array[len = 30].slice(5, 20).is_null()` would fail?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org