branch update - werkz guru needed :)

[Brett Porter <bp...@f2network.com.au>]

Hi,
 
Ok, I have touchstone fully working now and the plugins I have tested (in
particular xdoc and site) have behaved well in isolation, however, I've
identified two issues:
- preGoals/postGoals in maven.xml and driver.jelly get run twice. I know why
this is - I run them manually at the start, and they get included as plugins
and so they get run again, setting up two callbacks. Disabling the run
manually at the start is no good, because it is used to define the order of
precedence for overrides. I can disable the second run, but that causes
goals not to be found and this is where I got stumped this morning. I will
investigate more, but if any werkz gurus want to take a look over the next
commit I'd appreciate it.
- jelly contexts are possibly not being stacked properly when using the
reactor. If I run maven site with the junit-report plugin on maven,
test:test runs first, which runs the touchstone. This succeeds, but then
site ends up being run from the last project executed by the touchstone
reactor. I haven't looked into this yet, but I think it isn't a big deal.
 
The trivial bugs left to fix are:
- no project.xml doesn't work, NPE trying to validate the dependencies.
- goal names aren't echoed to the right place
- failures aren't reporting the plugin line number like they used to
 
Other than that, the only problems I know of are checkstyle (which I think
dIon's commit has fixed - I didn't want to modify it, but maybe that's one
thing we can afford to break in the RC for existing stuff as its a bad idea
anyway). I haven't tested simian's building since - it may now be working.
 
Cheers,
Brett
 
--
Brett Porter
Team Leader, Core Systems
f2 network ~ everything essential
 

Re: branch update - werkz guru needed :)

[Jason van Zyl <jv...@maven.org>]

On Tue, 2003-12-09 at 17:50, Brett Porter wrote:
> Hi,
>  
> Ok, I have touchstone fully working now and the plugins I have tested (in
> particular xdoc and site) have behaved well in isolation, however, I've
> identified two issues:
> - preGoals/postGoals in maven.xml and driver.jelly get run twice. I know why
> this is - I run them manually at the start, and they get included as plugins
> and so they get run again, setting up two callbacks. Disabling the run
> manually at the start is no good, because it is used to define the order of
> precedence for overrides. I can disable the second run, but that causes
> goals not to be found and this is where I got stumped this morning. I will
> investigate more, but if any werkz gurus want to take a look over the next
> commit I'd appreciate it.

If you have a little test that shows the problem I can help you track it
down.

> - jelly contexts are possibly not being stacked properly when using the
> reactor. If I run maven site with the junit-report plugin on maven,
> test:test runs first, which runs the touchstone. This succeeds, but then
> site ends up being run from the last project executed by the touchstone
> reactor. I haven't looked into this yet, but I think it isn't a big deal.
>  
> The trivial bugs left to fix are:
> - no project.xml doesn't work, NPE trying to validate the dependencies.
> - goal names aren't echoed to the right place
> - failures aren't reporting the plugin line number like they used to
>  
> Other than that, the only problems I know of are checkstyle (which I think
> dIon's commit has fixed - I didn't want to modify it, but maybe that's one
> thing we can afford to break in the RC for existing stuff as its a bad idea
> anyway). I haven't tested simian's building since - it may now be working.
>  
> Cheers,
> Brett
>  
> --
> Brett Porter
> Team Leader, Core Systems
> f2 network ~ everything essential
>  
-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org