You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/17 10:41:48 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35892: [SPARK-38575][INFRA][FOLLOW-UP] Use GITHUB_REF to get the current branch

HyukjinKwon commented on a change in pull request #35892:
URL: https://github.com/apache/spark/pull/35892#discussion_r828982178



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -96,7 +96,7 @@ jobs:
           echo '::set-output name=hadoop::hadoop3'
         else
           echo '::set-output name=java::8'
-          echo "::set-output name=branch::`git branch --show-current`"
+          echo "::set-output name=branch::${GITHUB_REF#refs/heads/}"

Review comment:
       Ah .. this has to be a `master` because we run this workflow in the forked repository. There is no way to get the target branch name in the forked repository workflow run ...
   
   I don't think there's an easy way to automatically find the nearest branch in the branch of the forked repository ... I will pin this to `master`. We will have to update this one place when we cut the branch next time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org