[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

["pgaref (via GitHub)" <gi...@apache.org>]

pgaref commented on code in PR #21923:
URL: https://github.com/apache/flink/pull/21923#discussion_r1163517899


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -980,8 +963,7 @@ protected CompletableFuture<Void> getCompletionFuture() {
 
     @Override
     public final void cancel() throws Exception {
-        isRunning = false;
-        canceled = true;
+        taskState.canceled = true;

Review Comment:
   Hey @rkhachatryan , thanks for taking another look!
   
   Just wanted to maintain the existing logic where both flags (running and canceled are true) but thinking it over looks like we only need to protect from the invalid transition: Canceled to Running (already enforced) -- WDYT?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org