[jira] [Commented] (LIBCLOUD-689) EC2: create_node ignores errors in ex_create_tags

["Tom Morris (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081279#comment-16081279 ] 

Tom Morris commented on LIBCLOUD-689:
-------------------------------------

This is a duplicate of LIBCLOUD-690

> EC2: create_node ignores errors in ex_create_tags
> -------------------------------------------------
>
>                 Key: LIBCLOUD-689
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-689
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: Stefan Friesel
>            Priority: Minor
>
> This was introduced in 796f6f2c (Wrap ex_create_tags call inside create_node in a try / except block and for now ignore tag creation errors.). If the intent was that the call should not abort after the original RunInstance request finished successfully, failure to create the tags should at least be indicated by not updating node.extra['tags'].
> I would argue though that potentially ignoring the name and ex_metadata parameters puts a lot of uncertainty in this method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)