You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by zenfenan <gi...@git.apache.org> on 2018/04/28 12:26:10 UTC
[GitHub] nifi pull request #2664: NIFI-5105: Improvements for nifi-aws-bundle
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/2664
NIFI-5105: Improvements for nifi-aws-bundle
Introduces the following improvements:
- The AWS SDK version has been updated to the latest release (1.11.319)
- Removed `aws-java-sdk` which packed unnecessary artifacts i.e. artifacts not used by the `nifi-aws-bundle`. The `nifi-aws-nar` now weights ~50 MB less
Test with S3 and it works well.
---
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-5105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2664
----
----
---
[GitHub] nifi pull request #2664: NIFI-5105: Improvements for nifi-aws-bundle
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2664
---
[GitHub] nifi issue #2664: NIFI-5105: Improvements for nifi-aws-bundle
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2664
Thanks, @zenfenan, this looks good.
- Full build with contrib-check passes
- nifi-aws-processors integration tests pass
- Manual testing with an S3 flow worked fine
And great news that the NAR file is down to ~15 MB!
---
[GitHub] nifi issue #2664: NIFI-5105: Improvements for nifi-aws-bundle
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2664
Reviewing...
---