[GitHub] drill issue #776: DRILL-5165: limitRel to return correct rows for limit all ...

[chunhui-shi <gi...@git.apache.org>]

Github user chunhui-shi commented on the issue:

    https://github.com/apache/drill/pull/776
  
    It failed without the fix.
    
    ________________________________
    From: Jinfeng Ni <no...@github.com>
    Sent: Wednesday, March 8, 2017 10:56:06 AM
    To: apache/drill
    Cc: Chunhui Shi; Author
    Subject: Re: [apache/drill] DRILL-5165: limitRel to return correct rows for limit all case (#776)
    
    
    @jinfengni commented on this pull request.
    
    ________________________________
    
    In exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java<https://github.com/apache/drill/pull/776#discussion_r104993761>:
    
    > @@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception {
         }
       }
    
    +  @Test
    +  public void TestLimitAllOnParquet() throws Exception {
    
    
    Have you tried this new testcase without the change above? Will it successful or fail?
    
    \u2014
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub<https://github.com/apache/drill/pull/776#pullrequestreview-25853026>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJa9A-HOKR8SCsdrPSb_457T4kbuelsBks5rjvnGgaJpZM4MWjjd>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---