You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2024/03/26 04:23:43 UTC
[PR] Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 in /sdks [beam]
dependabot[bot] opened a new pull request, #30745:
URL: https://github.com/apache/beam/pull/30745
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.7.1 to 1.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/go-sql-driver/mysql/releases">github.com/go-sql-driver/mysql's releases</a>.</em></p>
<blockquote>
<h2>v1.8.0</h2>
<h2>What's Changed</h2>
<h2>Major changes</h2>
<ul>
<li>
<p>Use <code>SET NAMES charset COLLATE collation</code>. by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1437">go-sql-driver/mysql#1437</a></p>
<ul>
<li>Older go-mysql-driver used <code>collation_id</code> in the handshake packet. But it caused collation mismatch in some situation.</li>
<li>If you don't specify charset nor collation, go-mysql-driver sends <code>SET NAMES utf8mb4</code> for new connection. This uses server's default collation for utf8mb4.</li>
<li>If you specify charset, go-mysql-driver sends <code>SET NAMES <charset></code>. This uses the server's default collation for <code><charset></code>.</li>
<li>If you specify collation and/or charset, go-mysql-driver sends <code>SET NAMES charset COLLATE collation</code>.</li>
</ul>
</li>
<li>
<p>PathEscape dbname in DSN. by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1432">go-sql-driver/mysql#1432</a></p>
<ul>
<li>This is backward incompatible in rare case. Check your DSN.</li>
</ul>
</li>
<li>
<p>Drop Go 1.13-17 support by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1420">go-sql-driver/mysql#1420</a></p>
<ul>
<li>Use Go 1.18+</li>
</ul>
</li>
<li>
<p>Parse numbers on text protocol too by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1452">go-sql-driver/mysql#1452</a></p>
<ul>
<li>When text protocol is used, go-mysql-driver passed bare <code>[]byte</code> to database/sql for avoid unnecessary allocation and conversion.</li>
<li>If user specified <code>*any</code> to <code>Scan()</code>, database/sql passed the <code>[]byte</code> into the target variabe.</li>
<li>This confused users because most user doesn't know when text/binary protocol used.</li>
<li>go-mysql-driver 1.8 converts integer/float values into int64/double even in text protocol. This doesn't increase allocation compared to <code>[]byte</code> and conversion cost is negilible.</li>
</ul>
</li>
<li>
<p>New options start using the Functional Option Pattern to avoid increasing technical debt in the Config object. Future version may introduce Functional Option for existing options, but not for now.</p>
<ul>
<li>Make TimeTruncate functional option by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1552">go-sql-driver/mysql#1552</a></li>
<li>Add BeforeConnect callback to configuration object by <a href="https://github.com/ItalyPaleAle"><code>@ItalyPaleAle</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1469">go-sql-driver/mysql#1469</a></li>
</ul>
</li>
</ul>
<h3>Other changes</h3>
<ul>
<li>
<p>Adding DeregisterDialContext to prevent memory leaks with dialers we don't need anymore by <a href="https://github.com/jypelle"><code>@jypelle</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1422">go-sql-driver/mysql#1422</a></p>
</li>
<li>
<p>Make logger configurable per connection by <a href="https://github.com/frozenbonito"><code>@frozenbonito</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1408">go-sql-driver/mysql#1408</a></p>
</li>
<li>
<p>Fix ColumnType.DatabaseTypeName for mediumint unsigned by <a href="https://github.com/evanelias"><code>@evanelias</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1428">go-sql-driver/mysql#1428</a></p>
</li>
<li>
<p>Add connection attributes by <a href="https://github.com/Daemonxiao"><code>@Daemonxiao</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1389">go-sql-driver/mysql#1389</a></p>
</li>
<li>
<p>Stop <code>ColumnTypeScanType()</code> from returning <code>sql.RawBytes</code> by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1424">go-sql-driver/mysql#1424</a></p>
</li>
<li>
<p>Exec() now provides access to status of multiple statements. by <a href="https://github.com/mherr-google"><code>@mherr-google</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1309">go-sql-driver/mysql#1309</a></p>
</li>
<li>
<p>Allow to change (or disable) the default driver name for registration by <a href="https://github.com/dolmen"><code>@dolmen</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1499">go-sql-driver/mysql#1499</a></p>
</li>
<li>
<p>Add default connection attribute '_server_host' by <a href="https://github.com/oblitorum"><code>@oblitorum</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1506">go-sql-driver/mysql#1506</a></p>
</li>
<li>
<p>QueryUnescape DSN ConnectionAttribute value by <a href="https://github.com/zhangyangyu"><code>@zhangyangyu</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1470">go-sql-driver/mysql#1470</a></p>
</li>
<li>
<p>Add client_ed25519 authentication by <a href="https://github.com/Gusted"><code>@Gusted</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1518">go-sql-driver/mysql#1518</a></p>
</li>
<li>
<p>Reduced allocation on connection.go by <a href="https://github.com/EPuncker"><code>@EPuncker</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1421">go-sql-driver/mysql#1421</a></p>
</li>
<li>
<p>Avoid panic in TestRowsColumnTypes by <a href="https://github.com/wayyoungboy"><code>@wayyoungboy</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1426">go-sql-driver/mysql#1426</a></p>
</li>
<li>
<p>Add benchmark to receive massive rows. by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1415">go-sql-driver/mysql#1415</a></p>
</li>
<li>
<p>README: Update multistatement by <a href="https://github.com/methane"><code>@methane</code></a> in <a href="https://redirect.github.com/go-sql-driver/mysql/pull/1431">go-sql-driver/mysql#1431</a></p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/go-sql-driver/mysql/commit/33b7747a9144946e50399904d3f27ecc0f96c2b6"><code>33b7747</code></a> Add BeforeConnect callback to configuration object (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1469">#1469</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/6964272ffd13a41ad66383cd2ea738fded75ad06"><code>6964272</code></a> Make TimeTruncate functional option (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1552">#1552</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/097fe6e3ad83bbd7c84debe810aec4c4a533bcaa"><code>097fe6e</code></a> Update workflows (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1547">#1547</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/f019727e4706bf9c4f60579382f6e72b94bd0305"><code>f019727</code></a> add TiDB support in README.md (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1333">#1333</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/743e263bab87912dfb61789f36c21d9685887c76"><code>743e263</code></a> Introduce <code>timeTruncate</code> parameter for <code>time.Time</code> arguments (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1541">#1541</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/c48c0e7da17e8fc06133e431ce7c10e7a3e94f06"><code>c48c0e7</code></a> Fix unsigned int overflow (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1530">#1530</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/0004702b931d3429afb3e16df444ed80be24d1f4"><code>0004702</code></a> Parallelize test (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1525">#1525</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/d4517c5d905ccd3cc1e750f592edfa88d774d908"><code>d4517c5</code></a> Support ENUM and SET type in DatabaseTypeName() (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1520">#1520</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/2cdf62442f2edb873d1270897d994fc83b78f118"><code>2cdf624</code></a> Fix sql.RawBytes corruption issue (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1523">#1523</a>)</li>
<li><a href="https://github.com/go-sql-driver/mysql/commit/fc589cbaba22032382488393c72b9b3b5366917c"><code>fc589cb</code></a> Add client_ed25519 authentication (<a href="https://redirect.github.com/go-sql-driver/mysql/issues/1518">#1518</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/go-sql-driver/mysql/compare/v1.7.1...v1.8.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 in /sdks [beam]
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse merged PR #30745:
URL: https://github.com/apache/beam/pull/30745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 in /sdks [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30745:
URL: https://github.com/apache/beam/pull/30745#issuecomment-2019398533
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 in /sdks [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #30745:
URL: https://github.com/apache/beam/pull/30745#issuecomment-2019365573
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30745?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 71.46%. Comparing base [(`c8ad120`)](https://app.codecov.io/gh/apache/beam/commit/c8ad120bde8cd3170c31ef18e04906d549a5c40b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d90417e`)](https://app.codecov.io/gh/apache/beam/pull/30745?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #30745 +/- ##
==========================================
- Coverage 71.47% 71.46% -0.01%
==========================================
Files 710 710
Lines 104795 104795
==========================================
- Hits 74899 74896 -3
- Misses 28264 28266 +2
- Partials 1632 1633 +1
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/30745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/30745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.32% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/30745?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org