You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/29 15:53:18 UTC

[GitHub] [airflow] NBardelot opened a new pull request #9065: ADD ldap and self-signed certificate

NBardelot opened a new pull request #9065:
URL: https://github.com/apache/airflow/pull/9065


   Fixes issue #9063 : LDAPS forces ssl.CERT_REQUIRED preventing the use of self-signed certificates 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryw commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
ryw commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-679199945


   @NBardelot would you like to close out this issue (see rebase request) or hand it off to someone else?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] prakshalj0512 commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
prakshalj0512 commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-675606979


   @NBardelot Thanks for creating this. Been really useful to me lately!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-706789511


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-667498087


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kurtqq commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
kurtqq commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-757377078


   can this fix be compatible with airflow 2??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-644061742


   @NBardelot Please rebase -- we hadn't yet cherry-picked the change to run tests against v1-10-stable branch. I have just done that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-758081079


   This LDAP code doesn't exist in Airflow anymore, we only use the LDAP code from Flask-AppBuilder.
   
   I'm going to close this as "wont-fix" now, as 2.0 is out and uses https://flask-appbuilder.readthedocs.io/en/latest/security.html?highlight=ldap#authentication-ldap


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kurtqq commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
kurtqq commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-757377078


   can this fix be compatible with airflow 2??


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb closed pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
ashb closed pull request #9065:
URL: https://github.com/apache/airflow/pull/9065


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-667537413


   Hey @NBardelot - seems useful. Would you mind rebasing please ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9065: ADD ldap and self-signed certificate

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9065:
URL: https://github.com/apache/airflow/pull/9065#issuecomment-669933322


   Can you add some tests?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org