You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kevinjmh <gi...@git.apache.org> on 2018/07/24 07:01:13 UTC
[GitHub] carbondata pull request #2545: [CARBONDATA-2774][BloomDataMap] Exception sho...
GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2545
[CARBONDATA-2774][BloomDataMap] Exception should be thrown if expression do not satisfy bloomFilter's requirement
If query on string column with bloom index using number as filter value, we would get wrong result. Because DDL will wrap the filter with a datatype conversion, and DatamapChooser chooses datamap by searching column deep down to all children of filter expression. However, bloom filter required the expression is simply `column =/in filterValue`. Else no querymodel is built and no hit blocklet so that we will get an empty result.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata bloom_wrongdatatype
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2545
----
commit bca3e23c2f23b8fbd0f179b0fe57b758efe4ff07
Author: Manhua <ke...@...>
Date: 2018-07-24T06:51:18Z
thrown an exception when build query model failed in bloom
----
---
[GitHub] carbondata issue #2545: [CARBONDATA-2774][BloomDataMap] Exception should be ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2545
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6194/
---
[GitHub] carbondata issue #2545: [CARBONDATA-2774][BloomDataMap] Exception should be ...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2545
LGTM
---
[GitHub] carbondata pull request #2545: [CARBONDATA-2774][BloomDataMap] Exception sho...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2545
---
[GitHub] carbondata issue #2545: [CARBONDATA-2774][BloomDataMap] Exception should be ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2545
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7437/
---
[GitHub] carbondata issue #2545: [CARBONDATA-2774][BloomDataMap] Exception should be ...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2545
As we discussed offline, the internal reason lies in DataMapChooser.chooseDataMap or BloomDataMapFactory.prune.
If the expression can not be handled by BloomFilter, the chooser should not forwarded it to BloomFilter
---