You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2014/03/06 22:50:19 UTC

svn commit: r1575059 - in /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase: io/hfile/HFile.java master/SplitLogManager.java

Author: tedyu
Date: Thu Mar  6 21:50:19 2014
New Revision: 1575059

URL: http://svn.apache.org/r1575059
Log:
HBASE-10693 Correct declarations of Atomic* fields from 'volatile' to 'final' (Honghua)


Modified:
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java?rev=1575059&r1=1575058&r2=1575059&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java Thu Mar  6 21:50:19 2014
@@ -249,7 +249,7 @@ public class HFile {
   }
 
   // for test purpose
-  public static volatile AtomicLong dataBlockReadCnt = new AtomicLong(0);
+  public static final AtomicLong dataBlockReadCnt = new AtomicLong(0);
 
   // number of sequential reads
   public static final int getReadOps() {

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java?rev=1575059&r1=1575058&r2=1575059&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java Thu Mar  6 21:50:19 2014
@@ -1294,7 +1294,7 @@ public class SplitLogManager extends Zoo
     volatile TaskBatch batch;
     volatile TerminationStatus status;
     volatile int incarnation;
-    volatile AtomicInteger unforcedResubmits = new AtomicInteger();
+    final AtomicInteger unforcedResubmits = new AtomicInteger();
     volatile boolean resubmitThresholdReached;
 
     @Override