[GitHub] [spark] HyukjinKwon commented on a change in pull request #31744: [WIP] Enable Arrow optimization for float types with SparkR

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31744:
URL: https://github.com/apache/spark/pull/31744#discussion_r587958938



##########
File path: R/pkg/R/types.R
##########
@@ -94,20 +94,7 @@ checkSchemaInArrow <- function(schema) {
 
   # Both cases below produce a corrupt value for unknown reason. It needs to be investigated.
   field_strings <- sapply(schema$fields(), function(x) x$dataType.toString())
-  if (any(field_strings == "FloatType")) {

Review comment:
       Sounds good. Can we add a test case? I think you can update the test cases with post-fix "- type specification" at test_sparkSQL_arrow.R 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org