You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AlexanderShoshin <gi...@git.apache.org> on 2017/03/24 12:45:51 UTC
[GitHub] zeppelin pull request #2188: [MINOR] Job parameters synchronization
GitHub user AlexanderShoshin opened a pull request:
https://github.com/apache/zeppelin/pull/2188
[MINOR] Job parameters synchronization
### What is this PR for?
We need to synchronize setting up job result, exception, errorMessage and dateFinished in the end of `Job.run()` method. This will guarantee that we won't see these parameters in inconsistent state in multithreading environment, e.g., if we see that a dateFinished parameter has not been set up yet we will be sure that we also don't have a job final result.
This code refactoring will make it possible to resolve issue [ZEPPELIN-1856](https://issues.apache.org/jira/browse/ZEPPELIN-1856).
### What type of PR is it?
Refactoring
### Todos
* [ ] - Synchronize `setResult()`, `exception`, `errorMessage` and `dateFinished` in `Job.run()` method.
* [ ] - Synchronize getters and setters for `exception`, `errorMessage` and `dateFinished`.
### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexanderShoshin/zeppelin job-results-synchronization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2188
----
commit bc9bbc91918984f1141b9f946f701ad616c5fe1f
Author: Alexander Shoshin <al...@epam.com>
Date: 2017-03-23T13:12:24Z
setting job results, error, dateFinished were synchronized
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2188: [MINOR] Job parameters synchronization
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2188
Thanks for the contribution!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2188: [MINOR] Job parameters synchronization
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2188
Merged to master, but didn't merged to branch-0.7 because of conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2188: [MINOR] Job parameters synchronization
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2188: [MINOR] Job parameters synchronization
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2188
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---