[GitHub] [incubator-milagro-MPC] kealan commented on a diff in pull request #42: feat: update ubuntu image, speed up buildtime

[GitBox <gi...@apache.org>]

kealan commented on code in PR #42:
URL: https://github.com/apache/incubator-milagro-MPC/pull/42#discussion_r885542807


##########
Dockerfile:
##########
@@ -24,7 +24,7 @@
 #     docker run -it --rm libmpc bash
 # ------------------------------------------------------------------------------
 
-FROM ubuntu:bionic
+FROM ubuntu:latest

Review Comment:
   Do we not want to have a named version - maybe focal?



##########
Dockerfile:
##########
@@ -46,15 +46,15 @@ RUN git clone https://github.com/apache/incubator-milagro-crypto-c.git && \
     cd build && \
     cmake -D CMAKE_BUILD_TYPE=Release -D BUILD_SHARED_LIBS=ON -D AMCL_CHUNK=64 -D AMCL_CURVE="BLS381,SECP256K1" -D AMCL_RSA="" -D BUILD_PAILLIER=ON -D BUILD_PYTHON=OFF -D BUILD_BLS=ON -D BUILD_WCC=OFF -D BUILD_MPIN=OFF -D BUILD_X509=OFF -D CMAKE_INSTALL_PREFIX=/usr/local .. && \
     make && \
-    make test  ARGS=-j8 && \
-    make install
+    make test ARGS=-j8 && \
+    make install/fast
 
 ADD . /root
 
 RUN ./scripts/build.sh
 
 RUN cd ./target/Release && \
-    make install
+    make -j8 install

Review Comment:
   That is a good all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org