You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/07 05:27:23 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10496: MINOR: move NoOpSnapshotWriter to main

cmccabe commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608349100



##########
File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -208,8 +208,7 @@ public QuorumController build() throws Exception {
                     "org.apache.kafka.controller.MockControllerMetrics").getConstructor().newInstance();

Review comment:
       It's not an issue because of the way it's used in the code.  But we will probably clean this up a little bit in a follow-on PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org