[GitHub] [skywalking] pg-yang commented on a diff in pull request #10645: Support Amazon API Gateway monitoring

["pg-yang (via GitHub)" <gi...@apache.org>]

pg-yang commented on code in PR #10645:
URL: https://github.com/apache/skywalking/pull/10645#discussion_r1157263634


##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java:
##########
@@ -464,7 +464,7 @@ public SampleFamily instance(List<String> serviceKeys, List<String> instanceKeys
         return instance(serviceKeys, Const.POINT, instanceKeys, Const.POINT, layer, null);
     }
 
-    public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys, Layer layer) {
+    public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys, String delimiter, Layer layer) {

Review Comment:
   As mentioned above,  `router` is made by `Method(route method)` and `Resource(route path)` such as `GET /students`.
   `endpoint(['service_name'],['Method','Resource'], Layer.AWS_GATEWAY)`  will generate an endpoint that contains a dot by default, such as `GET./students`. It's better to use space to replace dot to display.
   
   Alternative, ` tags.endpoint_name= tags.Method+' '+tags.Resource` also could generate an endpoint with a space delimiter.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org