You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/06/28 14:40:18 UTC

[superset] branch master updated: fix: Release scripts Python version (#24544)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new a90f740a81 fix: Release scripts Python version (#24544)
a90f740a81 is described below

commit a90f740a815828e48672872cfb96bfd7f477de2d
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Wed Jun 28 11:40:10 2023 -0300

    fix: Release scripts Python version (#24544)
---
 RELEASING/Dockerfile.from_local_tarball | 2 +-
 RELEASING/Dockerfile.from_svn_tarball   | 2 +-
 RELEASING/Dockerfile.make_docs          | 2 +-
 RELEASING/Dockerfile.make_tarball       | 2 +-
 RELEASING/README.md                     | 4 ++--
 RELEASING/from_tarball_entrypoint.sh    | 5 ++++-
 6 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/RELEASING/Dockerfile.from_local_tarball b/RELEASING/Dockerfile.from_local_tarball
index b55bbe870b..e62f409feb 100644
--- a/RELEASING/Dockerfile.from_local_tarball
+++ b/RELEASING/Dockerfile.from_local_tarball
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM python:3.8-buster
+FROM python:3.9-buster
 
 RUN useradd --user-group --create-home --no-log-init --shell /bin/bash superset
 
diff --git a/RELEASING/Dockerfile.from_svn_tarball b/RELEASING/Dockerfile.from_svn_tarball
index 3deea5b8d3..308adc73eb 100644
--- a/RELEASING/Dockerfile.from_svn_tarball
+++ b/RELEASING/Dockerfile.from_svn_tarball
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM python:3.8-buster
+FROM python:3.9-buster
 
 RUN useradd --user-group --create-home --no-log-init --shell /bin/bash superset
 
diff --git a/RELEASING/Dockerfile.make_docs b/RELEASING/Dockerfile.make_docs
index edb9c77569..eaa59c34ab 100644
--- a/RELEASING/Dockerfile.make_docs
+++ b/RELEASING/Dockerfile.make_docs
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM python:3.8-buster
+FROM python:3.9-buster
 ARG VERSION
 
 RUN git clone --depth 1 --branch ${VERSION} https://github.com/apache/superset.git /superset
diff --git a/RELEASING/Dockerfile.make_tarball b/RELEASING/Dockerfile.make_tarball
index 3e50eb41a9..59a306fbf4 100644
--- a/RELEASING/Dockerfile.make_tarball
+++ b/RELEASING/Dockerfile.make_tarball
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-FROM python:3.8-buster
+FROM python:3.9-buster
 
 RUN apt-get update -y
 RUN apt-get install -y jq
diff --git a/RELEASING/README.md b/RELEASING/README.md
index 901d21aefb..ab0c6735d1 100644
--- a/RELEASING/README.md
+++ b/RELEASING/README.md
@@ -74,7 +74,7 @@ the repo directly from the main `apache/superset` repo to a new directory `super
 
 ```bash
 cd <MY PROJECTS PATH>
-git clone git@github.com:apache/superset.git superset-release
+git clone https://github.com/apache/superset.git superset-release
 cd superset-release
 ```
 
@@ -102,7 +102,7 @@ the same terminal session won't be used for crafting the release candidate and t
 final release. Therefore, it's a good idea to do the following every time you
 work on a new phase of the release process to make sure you aren't releasing
 the wrong files/using wrong names. There's a script to help you set correctly all the
-necessary environment variables. Change your current directory to `superset/RELEASING`
+necessary environment variables. Change your current directory to `RELEASING`
 and execute the `set_release_env.sh` script with the relevant parameters:
 
 Usage (MacOS/ZSH):
diff --git a/RELEASING/from_tarball_entrypoint.sh b/RELEASING/from_tarball_entrypoint.sh
index 27b247eb72..aae08a53c4 100755
--- a/RELEASING/from_tarball_entrypoint.sh
+++ b/RELEASING/from_tarball_entrypoint.sh
@@ -19,7 +19,10 @@ set -ex
 
 echo "[WARNING] this entrypoint creates an admin/admin user"
 echo "[WARNING] it should only be used for lightweight testing/validation"
-if $SUPERSET_TESTENV then echo "SUPERSET IS RUNNING IN TEST MODE"
+
+if [ -z "${SUPERSET_TESTENV}" ]; then
+  echo "SUPERSET IS RUNNING IN TEST MODE"
+fi
 
 # Create an admin user (you will be prompted to set username, first and last name before setting a password)
 superset fab create-admin \