You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ndimiduk (via GitHub)" <gi...@apache.org> on 2023/03/03 12:10:18 UTC

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5036: HBASE-27652 Client-side lock contention around Configuration when using read replica regions

ndimiduk commented on code in PR #5036:
URL: https://github.com/apache/hbase/pull/5036#discussion_r1124369544


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##########
@@ -71,30 +71,41 @@ public <T> RpcRetryingCaller<T> newCaller() {
       interceptor, startLogErrorsCnt, connectionConf.getRpcTimeout(), metrics);
   }
 
-  public static RpcRetryingCallerFactory instantiate(Configuration configuration,
+  @RestrictedApi(explanation = "Should only be called on process initialization", link = "",
+    allowedOnPath = ".*/hbase-server/src/main/java/.*/(HRegionServer|LoadIncrementalHFiles|SecureBulkLoadClient)\\.java")
+  public static RpcRetryingCallerFactory instantiate(Configuration configuration, MetricsConnection metrics) {
+    return instantiate(configuration, new ConnectionConfiguration(configuration), metrics);
+  }
+
+  public static RpcRetryingCallerFactory instantiate(Configuration configuration, ConnectionConfiguration connectionConf,
     MetricsConnection metrics) {
-    return instantiate(configuration, RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, null,
+    return instantiate(configuration, connectionConf, RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, null,
       metrics);
   }
 
-  public static RpcRetryingCallerFactory instantiate(Configuration configuration,
+  public static RpcRetryingCallerFactory instantiate(Configuration configuration, ConnectionConfiguration connectionConf,
     ServerStatisticTracker stats, MetricsConnection metrics) {
-    return instantiate(configuration, RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, stats,
+    return instantiate(configuration, connectionConf, RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, stats,
       metrics);
   }
 
-  public static RpcRetryingCallerFactory instantiate(Configuration configuration,
+  public static RpcRetryingCallerFactory instantiate(Configuration configuration, ConnectionConfiguration connectionConf,
     RetryingCallerInterceptor interceptor, ServerStatisticTracker stats,
     MetricsConnection metrics) {
     String clazzName = RpcRetryingCallerFactory.class.getName();
     String rpcCallerFactoryClazz =
       configuration.get(RpcRetryingCallerFactory.CUSTOM_CALLER_CONF_KEY, clazzName);
     RpcRetryingCallerFactory factory;
     if (rpcCallerFactoryClazz.equals(clazzName)) {

Review Comment:
   Hmm yes, I suppose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org