You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mayuehappy (via GitHub)" <gi...@apache.org> on 2023/08/08 13:01:22 UTC
[GitHub] [flink] mayuehappy opened a new pull request, #23169: draft:[FLINK-31238] Use IngestDB to speed up Rocksdb rescaling recovery
mayuehappy opened a new pull request, #23169:
URL: https://github.com/apache/flink/pull/23169
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery [flink]
Posted by "StefanRRichter (via GitHub)" <gi...@apache.org>.
StefanRRichter commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-2597766811
An improved version of this PR was already merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mayuehappy commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "mayuehappy (via GitHub)" <gi...@apache.org>.
mayuehappy commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1738372807
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1706441721
@pnowojski I think we might have two small problems to face:
1. We might face the performance regression on [micro-benchmarks](https://github.com/apache/flink-benchmarks/) after upgrading to RocksDB-8.x, just like we upgrade from 5.x to 6.x. However, I actually try to bump to RocksDB-7.x internally and found performance improvement due to the [compaction improvement](https://github.com/facebook/rocksdb/issues/9423). Since our micro-benchmarks cannot reflect the compaction problem, we can use nexmark to verify the end-to-end performance then.
2. Latest RocksDB supports a new platform: [s390x](https://github.com/facebook/rocksdb/issues/8698), we might not able to compile and get one binary `.so` file due to lacking machines. However, since our current version does not support that platform, we can launch an announcement/discussion to not support this new platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery [flink]
Posted by "StefanRRichter (via GitHub)" <gi...@apache.org>.
StefanRRichter closed pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
URL: https://github.com/apache/flink/pull/23169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mayuehappy commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "mayuehappy (via GitHub)" <gi...@apache.org>.
mayuehappy commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1711007885
> It looks like we will need to bump RocksDB from 6.20.x to 8.5.x
>
> > 8.5.0-ververica-1.0-db-SNASHOT
>
> @curcur or @Myasuka , do you know if there are any known hurdles that would prevent us from upgrading RocksDB atm?
> @mayuehappy thanks for the draft PR. General idea of the PR looks good to me, we should still polish it and avoid code duplication. I currently cannot test the PR because the frocksDB dependency is missing. How do you want to proceed with this?
@StefanRRichter
I’m not sure how the Flink community tested Frocksdb-jni before it was released. Is there a maven repository for testing where I can deploy my test-frocksdb-jar ? @Myasuka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mayuehappy commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "mayuehappy (via GitHub)" <gi...@apache.org>.
mayuehappy commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1736606123
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StefanRRichter commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "StefanRRichter (via GitHub)" <gi...@apache.org>.
StefanRRichter commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1719003134
@mayuehappy I think there is already a reply on the RocksDB PR. So if you think with their guidance it's now reasonable to assume this can be merged soon, then there is no need to merge early. But otherwise that would be an option to make progress on the Flink side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1706294807
It looks like we will need to bump RocksDB from 6.20.x to 8.5.x
> 8.5.0-ververica-1.0-db-SNASHOT
@curcur or @Myasuka , do you know if there are any known hurdles that would prevent us from upgrading RocksDB atm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StefanRRichter commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "StefanRRichter (via GitHub)" <gi...@apache.org>.
StefanRRichter commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1705309083
@mayuehappy thanks for the draft PR. General idea of the PR looks good to me, we should still polish it and avoid code duplication. I currently cannot test the PR because the frocksDB dependency is missing. How do you want to proceed with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-2596379535
This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 90 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23169: [FLINK-31238] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1669577021
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4851d9c9bda7063196389895988a091fda7f4a8f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4851d9c9bda7063196389895988a091fda7f4a8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4851d9c9bda7063196389895988a091fda7f4a8f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mayuehappy commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "mayuehappy (via GitHub)" <gi...@apache.org>.
mayuehappy commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1711009736
> @mayuehappy I noticed that one required PR against RocksDB ([facebook/rocksdb#11646](https://github.com/facebook/rocksdb/pull/11646)) is still not merged and the conversation is stalling. Do you think it's ok to ping Adam to take another look?
> @mayuehappy I noticed that one required PR against RocksDB ([facebook/rocksdb#11646](https://github.com/facebook/rocksdb/pull/11646)) is still not merged and the conversation is stalling. Do you think it's ok to ping Adam to take another look?
@StefanRRichter Thanks for the reminder, I've pinged him and cbi42 under the PR.
BTW, is it possible that we merge this part of the JNI code into frocksdb before they merge into rocksdb?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "fredia (via GitHub)" <gi...@apache.org>.
fredia commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1707800489
Newer versions of RocksDB are backward compatible, compatibility will not be a hindrance. https://github.com/facebook/rocksdb/wiki/RocksDB-Overview#compatibility
@Myasuka For [s390x](https://github.com/facebook/rocksdb/issues/8698), I think we can use [travis-ci](https://docs.travis-ci.com/user/multi-cpu-architectures/#multi-cpu-availability) to build one binary `.so` file if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1707941637
Ok, thanks @Myasuka and @fredia for the input. Yes will need to benchmark this both with micro and ideally macro benchmarks as well. I would hope there won't be a micro benchmark regression, and that 5.x -> 6.x was one of issue, but who knows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StefanRRichter commented on pull request #23169: [FLINK-31238] [WIP] Use IngestDB to speed up Rocksdb rescaling recovery
Posted by "StefanRRichter (via GitHub)" <gi...@apache.org>.
StefanRRichter commented on PR #23169:
URL: https://github.com/apache/flink/pull/23169#issuecomment-1710155209
@mayuehappy I noticed that one required PR against RocksDB (https://github.com/facebook/rocksdb/pull/11646) is still not merged and the conversation is stalling. Do you think it's ok to ping Adam to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org