You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:12:03 UTC
[GitHub] [arrow] dchigarev opened a new pull request #8578: ARROW-10479: [C++] Get rid of code duplication at decimal type builders
dchigarev opened a new pull request #8578:
URL: https://github.com/apache/arrow/pull/8578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dchigarev commented on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
dchigarev commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-767555220
@pitrou generally PR is ready, now I'm fixing CI issues caused by my incorrectly usage of `ARROW_EXPORT` attribute, I hope I'll have an opportunity to mark it as ready for review at the next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dchigarev commented on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
dchigarev commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-1052128679
The PR is pretty much outdated and would take a lot of effort to align it with the master I think. So it's better to close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dchigarev closed pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
dchigarev closed pull request #8578:
URL: https://github.com/apache/arrow/pull/8578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-887322545
@dchigarev This PR is still in draft. Are you planning to update and/or submit it?
(also, it would need rebasing on current master)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dchigarev edited a comment on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
dchigarev edited a comment on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-767555220
@pitrou generally PR is ready, now I'm fixing CI failures caused by my incorrectly usage of `ARROW_EXPORT` attribute, I hope I'll have an opportunity to mark it as ready for review at the next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-767547425
@dchigarev What is the status of this PR? Do you intend to finish working on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8578: ARROW-10479: [C++] Get rid of code duplication at decimal type builders
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-721103735
https://issues.apache.org/jira/browse/ARROW-10479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] baumgold commented on pull request #8578: ARROW-10479: [C++] Initial support of low bitness Decimals (16, 32, 64)
Posted by GitBox <gi...@apache.org>.
baumgold commented on pull request #8578:
URL: https://github.com/apache/arrow/pull/8578#issuecomment-1051369446
Hi. Any update here? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org