You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/10 13:30:17 UTC
Review Request 58297: Add stab registering and heartbeating routine
via stomp async calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-20721
https://issues.apache.org/jira/browse/AMBARI-20721
Repository: ambari
Description
-------
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
Diff: https://reviews.apache.org/r/58297/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/#review171440
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On \u041a\u0432\u0456\u0442\u0435\u043d\u044c 10, 2017, 4:35 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58297/
> -----------------------------------------------------------
>
> (Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 10, 2017, 4:35 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20721
> https://issues.apache.org/jira/browse/AMBARI-20721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As for registering and heartbeat we still require synchronious behaviour on agent side. This requires a dictionary with blocking pop with correlationId as keys.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58297/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On April 11, 2017, 6:42 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py
> > Lines 48 (patched)
> > <https://reviews.apache.org/r/58297/diff/3/?file=1687921#file1687921line48>
> >
> > Generally, add documentation to all classes and functions.
added in another patch
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/#review171604
-----------------------------------------------------------
On April 11, 2017, 10:57 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58297/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 10:57 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20721
> https://issues.apache.org/jira/browse/AMBARI-20721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As for registering and heartbeat we still require synchronious behaviour on agent side. This requires a dictionary with blocking pop with correlationId as keys.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
> ambari-common/src/test/python/coilmq/server/socket_server.py b4f081e
>
>
> Diff: https://reviews.apache.org/r/58297/diff/3/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/#review171604
-----------------------------------------------------------
Fix it, then Ship it!
Fix It and Ship It
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py
Lines 48 (patched)
<https://reviews.apache.org/r/58297/#comment244550>
Generally, add documentation to all classes and functions.
- Alejandro Fernandez
On April 11, 2017, 10:57 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58297/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 10:57 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20721
> https://issues.apache.org/jira/browse/AMBARI-20721
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As for registering and heartbeat we still require synchronious behaviour on agent side. This requires a dictionary with blocking pop with correlationId as keys.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
> ambari-common/src/test/python/coilmq/server/socket_server.py b4f081e
>
>
> Diff: https://reviews.apache.org/r/58297/diff/3/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/
-----------------------------------------------------------
(Updated April 11, 2017, 10:57 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20721
https://issues.apache.org/jira/browse/AMBARI-20721
Repository: ambari
Description
-------
As for registering and heartbeat we still require synchronious behaviour on agent side. This requires a dictionary with blocking pop with correlationId as keys.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
ambari-common/src/test/python/coilmq/server/socket_server.py b4f081e
Diff: https://reviews.apache.org/r/58297/diff/2/
Changes: https://reviews.apache.org/r/58297/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/
-----------------------------------------------------------
(Updated April 10, 2017, 1:35 p.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20721
https://issues.apache.org/jira/browse/AMBARI-20721
Repository: ambari
Description (updated)
-------
As for registering and heartbeat we still require synchronious behaviour on agent side. This requires a dictionary with blocking pop with correlationId as keys.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
Diff: https://reviews.apache.org/r/58297/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58297: Add stab registering and heartbeating
routine via stomp async calls.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58297/
-----------------------------------------------------------
(Updated April 10, 2017, 1:31 p.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20721
https://issues.apache.org/jira/browse/AMBARI-20721
Repository: ambari
Description (updated)
-------
.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Constants.py 6b80f00
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Utils.py e7b03f9
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/security.py 45de7bb
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 983b392
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/heartbeat_request.json PRE-CREATION
Diff: https://reviews.apache.org/r/58297/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk