You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/18 06:06:37 UTC
[GitHub] [flink] liuml07 opened a new pull request, #21343: [FLINK-30079][doc] Stop using deprecated TM options in doc
liuml07 opened a new pull request, #21343:
URL: https://github.com/apache/flink/pull/21343
## What is the purpose of the change
The option ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY was deprecated and configuring it should have no effect now. However, in the [documentation](https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/dev/dataset/local_execution/#local-environment) we still reference it and show in example code. This can be replaced with TaskManagerOptions.MANAGED_MEMORY_FRACTION.
## Brief change log
This can be replaced with TaskManagerOptions.MANAGED_MEMORY_FRACTION.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuml07 commented on pull request #21343: [FLINK-30079][doc] Stop using deprecated TM options in doc
Posted by GitBox <gi...@apache.org>.
liuml07 commented on PR #21343:
URL: https://github.com/apache/flink/pull/21343#issuecomment-1320431644
Thank you @zentol. TIL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21343: [FLINK-30079][doc] Stop using deprecated TM options in doc
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21343:
URL: https://github.com/apache/flink/pull/21343#discussion_r1026094609
##########
docs/content.zh/docs/dev/dataset/local_execution.md:
##########
@@ -97,7 +97,7 @@ The `LocalEnvironment` allows also to pass custom configuration values to Flink.
```java
Configuration conf = new Configuration();
-conf.setFloat(ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY, 0.5f);
+conf.setFloat(TaskManagerOptions.MANAGED_MEMORY_FRACTION, 0.5f);
Review Comment:
```suggestion
conf.set(TaskManagerOptions.MANAGED_MEMORY_FRACTION, 0.5f);
```
##########
docs/content/docs/dev/dataset/local_execution.md:
##########
@@ -97,7 +97,7 @@ The `LocalEnvironment` allows also to pass custom configuration values to Flink.
```java
Configuration conf = new Configuration();
-conf.setFloat(ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY, 0.5f);
+conf.setFloat(TaskManagerOptions.MANAGED_MEMORY_FRACTION, 0.5f);
Review Comment:
```suggestion
conf.set(TaskManagerOptions.MANAGED_MEMORY_FRACTION, 0.5f);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #21343: [FLINK-30079][doc] Stop using deprecated TM options in doc
Posted by GitBox <gi...@apache.org>.
zentol merged PR #21343:
URL: https://github.com/apache/flink/pull/21343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21343: [FLINK-30079][doc] Stop using deprecated TM options in doc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21343:
URL: https://github.com/apache/flink/pull/21343#issuecomment-1319592218
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f3b6580ba775e175cd691e529ad264a5268a60a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f3b6580ba775e175cd691e529ad264a5268a60a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f3b6580ba775e175cd691e529ad264a5268a60a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org