You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Hengruo Zhang <wh...@hengruo.me> on 2019/10/09 19:58:06 UTC
Can't find myself in contributor list
Hi,
My two PRs have been already merged to the master branch, but I cannot
see me in the contributor list of GitHub, even if I narrowed down the
time span so that there are only less than 50 people. And I can't even
find my merging in https://github.com/apache/arrow/pulse .
Could you please provide some possible reasons for this?
PRs:
https://github.com/apache/arrow/pull/5577
https://github.com/apache/arrow/pull/5303
Thanks,
Hengruo
Re: Can't find myself in contributor list
Posted by Hengruo Zhang <wh...@hengruo.me>.
Got it. 6408 was reverted. That makes sense.
On Wed, Oct 9, 2019 at 3:19 PM Wes McKinney <we...@gmail.com> wrote:
> I'm seeing
>
> $ git hist | grep Hengruo
> * f9cd2958a 2019-10-09 | ARROW-6274: [Rust] [DataFusion] Add support
> for writing results to CSV [Hengruo Zhang]
> * 3145e9bef 2019-09-08 | ARROW-6408: [Rust] use "if cfg!" pattern
> [Hengruo Zhang]
>
> So there's only 1 commit in the last 1 month. This doesn't appear to
> be enough to be guaranteed to show up in the Pulse view (1 week or 1
> month views)
>
> On Wed, Oct 9, 2019 at 4:53 PM paddy horan <pa...@hotmail.com> wrote:
> >
> > It might also be due to our merge tool. PRs are merged locally and
> pushed to master (with the corresponding PR on github being “closed” rather
> than “merged”). This might not be reflected in the pulse view.
> >
> > P
> >
> > ________________________________
> > From: Wes McKinney <we...@gmail.com>
> > Sent: Wednesday, October 9, 2019 4:06:59 PM
> > To: dev <de...@arrow.apache.org>
> > Subject: Re: Can't find myself in contributor list
> >
> > GitHub only shows the top 100 contributors to the project in
> >
> > https://github.com/apache/arrow/graphs/contributors
> >
> > Similarly I think you need more commits to show up in the Pulse view
> >
> > On Wed, Oct 9, 2019 at 2:58 PM Hengruo Zhang <wh...@hengruo.me> wrote:
> > >
> > > Hi,
> > >
> > > My two PRs have been already merged to the master branch, but I cannot
> > > see me in the contributor list of GitHub, even if I narrowed down the
> > > time span so that there are only less than 50 people. And I can't even
> > > find my merging in https://github.com/apache/arrow/pulse .
> > >
> > > Could you please provide some possible reasons for this?
> > >
> > > PRs:
> > > https://github.com/apache/arrow/pull/5577
> > > https://github.com/apache/arrow/pull/5303
> > >
> > > Thanks,
> > > Hengruo
>
Re: Can't find myself in contributor list
Posted by Wes McKinney <we...@gmail.com>.
I'm seeing
$ git hist | grep Hengruo
* f9cd2958a 2019-10-09 | ARROW-6274: [Rust] [DataFusion] Add support
for writing results to CSV [Hengruo Zhang]
* 3145e9bef 2019-09-08 | ARROW-6408: [Rust] use "if cfg!" pattern
[Hengruo Zhang]
So there's only 1 commit in the last 1 month. This doesn't appear to
be enough to be guaranteed to show up in the Pulse view (1 week or 1
month views)
On Wed, Oct 9, 2019 at 4:53 PM paddy horan <pa...@hotmail.com> wrote:
>
> It might also be due to our merge tool. PRs are merged locally and pushed to master (with the corresponding PR on github being “closed” rather than “merged”). This might not be reflected in the pulse view.
>
> P
>
> ________________________________
> From: Wes McKinney <we...@gmail.com>
> Sent: Wednesday, October 9, 2019 4:06:59 PM
> To: dev <de...@arrow.apache.org>
> Subject: Re: Can't find myself in contributor list
>
> GitHub only shows the top 100 contributors to the project in
>
> https://github.com/apache/arrow/graphs/contributors
>
> Similarly I think you need more commits to show up in the Pulse view
>
> On Wed, Oct 9, 2019 at 2:58 PM Hengruo Zhang <wh...@hengruo.me> wrote:
> >
> > Hi,
> >
> > My two PRs have been already merged to the master branch, but I cannot
> > see me in the contributor list of GitHub, even if I narrowed down the
> > time span so that there are only less than 50 people. And I can't even
> > find my merging in https://github.com/apache/arrow/pulse .
> >
> > Could you please provide some possible reasons for this?
> >
> > PRs:
> > https://github.com/apache/arrow/pull/5577
> > https://github.com/apache/arrow/pull/5303
> >
> > Thanks,
> > Hengruo
Re: Can't find myself in contributor list
Posted by paddy horan <pa...@hotmail.com>.
It might also be due to our merge tool. PRs are merged locally and pushed to master (with the corresponding PR on github being “closed” rather than “merged”). This might not be reflected in the pulse view.
P
________________________________
From: Wes McKinney <we...@gmail.com>
Sent: Wednesday, October 9, 2019 4:06:59 PM
To: dev <de...@arrow.apache.org>
Subject: Re: Can't find myself in contributor list
GitHub only shows the top 100 contributors to the project in
https://github.com/apache/arrow/graphs/contributors
Similarly I think you need more commits to show up in the Pulse view
On Wed, Oct 9, 2019 at 2:58 PM Hengruo Zhang <wh...@hengruo.me> wrote:
>
> Hi,
>
> My two PRs have been already merged to the master branch, but I cannot
> see me in the contributor list of GitHub, even if I narrowed down the
> time span so that there are only less than 50 people. And I can't even
> find my merging in https://github.com/apache/arrow/pulse .
>
> Could you please provide some possible reasons for this?
>
> PRs:
> https://github.com/apache/arrow/pull/5577
> https://github.com/apache/arrow/pull/5303
>
> Thanks,
> Hengruo
Re: Can't find myself in contributor list
Posted by Wes McKinney <we...@gmail.com>.
GitHub only shows the top 100 contributors to the project in
https://github.com/apache/arrow/graphs/contributors
Similarly I think you need more commits to show up in the Pulse view
On Wed, Oct 9, 2019 at 2:58 PM Hengruo Zhang <wh...@hengruo.me> wrote:
>
> Hi,
>
> My two PRs have been already merged to the master branch, but I cannot
> see me in the contributor list of GitHub, even if I narrowed down the
> time span so that there are only less than 50 people. And I can't even
> find my merging in https://github.com/apache/arrow/pulse .
>
> Could you please provide some possible reasons for this?
>
> PRs:
> https://github.com/apache/arrow/pull/5577
> https://github.com/apache/arrow/pull/5303
>
> Thanks,
> Hengruo