You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/07/30 13:23:33 UTC
[jira] [Created] (QPID-4172) [Java Broker] Virtualhost tasks should
reset their thread name upon completion
Robbie Gemmell created QPID-4172:
------------------------------------
Summary: [Java Broker] Virtualhost tasks should reset their thread name upon completion
Key: QPID-4172
URL: https://issues.apache.org/jira/browse/QPID-4172
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.16, 0.15, 0.14, 0.13, 0.12, 0.17, 0.18
Reporter: Robbie Gemmell
Priority: Minor
Fix For: 0.19
Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4172) [Java Broker] Virtualhost tasks
should reset their thread name upon completion
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-4172.
----------------------------------
Resolution: Fixed
Patch applied.
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4172) [Java Broker] Virtualhost tasks
should reset their thread name upon completion
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4172:
-----------------------------------
Assignee: Philip Harvey
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4172) [Java Broker] Virtualhost tasks should
reset their thread name upon completion
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-4172:
---------------------------------
Affects Version/s: (was: 0.18)
Fix Version/s: (was: 0.19)
0.18
Change merged to the 0.18 branch.
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.18
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4172) [Java Broker] Virtualhost tasks
should reset their thread name upon completion
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey reassigned QPID-4172:
-----------------------------------
Assignee: Alex Rudyy (was: Philip Harvey)
please review patch
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4172) [Java Broker] Virtualhost tasks should
reset their thread name upon completion
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4172:
--------------------------------
Status: Ready To Review (was: In Progress)
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4172) [Java Broker] Virtualhost tasks should
reset their thread name upon completion
Posted by "Philip Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Harvey updated QPID-4172:
--------------------------------
Attachment: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
attached patch - HouseKeepingTask now reverts thread name.
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Philip Harvey
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4172) [Java Broker] Virtualhost tasks
should reset their thread name upon completion
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-4172:
--------------------------------
Assignee: Robbie Gemmell (was: Alex Rudyy)
Reviewed with no comments.
Robbie,
Could you please commit the change
> [Java Broker] Virtualhost tasks should reset their thread name upon completion
> ------------------------------------------------------------------------------
>
> Key: QPID-4172
> URL: https://issues.apache.org/jira/browse/QPID-4172
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.12, 0.13, 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.19
>
> Attachments: 0001-QPID-4172-HouseKeepingTask-now-reverts-thread-name-b.patch
>
>
> Virtualhost tasks should reset their thread name upon completion should reset their thread name upon completion.
> We use a ScheduledThreadPoolExecutor for running Virtualhost level tasks such as TransactionTimeout, VirtualHostHouseKeepingTask, the UpdateTask, etc. These rename the thread at the start of their execution, but do not at the end (as explicitly noted in the code, remove the comment) because it will be reset at the next tasks execution. This can confusingly result in multiple threads with the same name if the pool allocates a task to different threads on subsequent executions, so the tasks should restore the original name when they complete to avoid confusion.
> This will result in the threads always having their generic thread pool name except when executing a given task. It might be useful if we could set the base name for these threads in some way to make them easier to identify, but this may not actually be possible while using a ScheduledThreadPoolExecutor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org