[GitHub] [tvm] Hzfengsy commented on a diff in pull request #15471: [ARITH] Enhance Canonical Simplify for LE

["Hzfengsy (via GitHub)" <gi...@apache.org>]

Hzfengsy commented on code in PR #15471:
URL: https://github.com/apache/tvm/pull/15471#discussion_r1283484467


##########
tests/python/unittest/test_target_codegen_c_host.py:
##########
@@ -64,7 +64,8 @@ def test_add_pipeline():
     s[C].pragma(xo1, "parallel_launch_point")
     s[C].pragma(xo2, "parallel_stride_pattern")
     s[C].pragma(xo2, "parallel_barrier_when_finish")
-    s[C].vectorize(xi)
+    # FIXME(tvm-team): vector operators are not supported for codegen to C yet

Review Comment:
   This case is because of the poor support of vectorization for c_codegen.
   Before this PR, TVM failed to simplify the branch predicate and skip the vectorization. This PR enhances the arith, and makes it TRUE vectoring, but failed on codegen stage.
   
   In short:
   1. It's not related to this PR, as it's codegen issue
   2. It's not a regression, vectorized step is skipped before this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org