You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/04/12 14:57:01 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708

damccorm commented on code in PR #26154:
URL: https://github.com/apache/beam/pull/26154#discussion_r1164261240


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -100,6 +100,8 @@ public boolean requiresDeduping() {
    * org.apache.beam.sdk.io.UnboundedSource.UnboundedReader}.
    *
    * <p>For example, this could be offsets in a set of files being read.
+   *
+   * <p>Note that: The implementations of this interface should be encodable (have an associated Coder).

Review Comment:
   ```suggestion
      * <p>Note that: The implementations of this interface should be encodable (have an associated
      * Coder).
   ```
   
   Our linter flagged this as exceeding our line limit - https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/26268/console
   
   You can also run `./gradlew :sdks:java:core:spotlessApply` from the repo root to apply fixes like this in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org