You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/05 08:31:28 UTC
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #959: wireless/gs2200m: replace the preamble scratch to union
anchao opened a new pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959
## Summary
wireless/gs2200m: replace the preamble scratch to union
## Impact
fix the preamble scratch buffer issue
## Testing
N/A, I do not have the wifi module....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #959: wireless/gs2200m: replace the preamble scratch to union
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778658794
##########
File path: wireless/gs2200m/gs2200m_main.c
##########
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s *priv)
return -EIO;
}
- assert(handlers[com_hdr->reqid].hdrlen < sizeof(hdrbuf));
+ assert(handlers[com_hdr->reqid].hdrlen < sizeof(req));
Review comment:
> Thanks for your quick reply, I will update here, will the spresense works properly if this change included?
Yes. (I'm still checking the ntp client stack corruption https://github.com/apache/incubator-nuttx-apps/pull/957 but the issue does not relate to this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #959: wireless/gs2200m: replace the preamble scratch to union
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #959: wireless/gs2200m: replace the preamble scratch to union
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959#issuecomment-1005480661
@masayuki2009 could you try the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #959: wireless/gs2200m: replace the preamble scratch to union
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778640247
##########
File path: wireless/gs2200m/gs2200m_main.c
##########
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s *priv)
return -EIO;
}
- assert(handlers[com_hdr->reqid].hdrlen < sizeof(hdrbuf));
+ assert(handlers[com_hdr->reqid].hdrlen < sizeof(req));
Review comment:
@anchao
I found that the assertion happend here.
I confirmed the following condition works.
```
assert(handlers[com_hdr->reqid].hdrlen <= sizeof(req));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request #959: wireless/gs2200m: replace the preamble scratch to union
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #959:
URL: https://github.com/apache/incubator-nuttx-apps/pull/959#discussion_r778644757
##########
File path: wireless/gs2200m/gs2200m_main.c
##########
@@ -389,17 +406,17 @@ static int usrsock_request(int fd, FAR struct gs2200m_s *priv)
return -EIO;
}
- assert(handlers[com_hdr->reqid].hdrlen < sizeof(hdrbuf));
+ assert(handlers[com_hdr->reqid].hdrlen < sizeof(req));
Review comment:
Thanks for your quick reply, I will update here, will the spresense works properly if this change included?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org