You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "jsteelepfpt (via GitHub)" <gi...@apache.org> on 2023/04/24 16:52:16 UTC
[GitHub] [directory-scimple] jsteelepfpt opened a new pull request, #290: Update ObjectMapperFactory.java
jsteelepfpt opened a new pull request, #290:
URL: https://github.com/apache/directory-scimple/pull/290
Enable the ObjectMapper to handle enums case-insensitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] bdemers commented on a diff in pull request #290: Update ObjectMapperFactory.java
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #290:
URL: https://github.com/apache/directory-scimple/pull/290#discussion_r1175598189
##########
scim-core/src/main/java/org/apache/directory/scim/core/json/ObjectMapperFactory.java:
##########
@@ -61,6 +61,7 @@ private static ObjectMapper createObjectMapper() {
objectMapper.setAnnotationIntrospector(pair);
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+ objectMapper.configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS, true);
Review Comment:
Great find!
Given that one major vendor does this, I'm plus one. It's not clear to me what the official RFC stance is, the closest I could find are these:
https://www.rfc-editor.org/rfc/rfc7644#section-3.10
https://datatracker.ietf.org/doc/html/rfc7643#section-2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] bdemers merged pull request #290: Update ObjectMapperFactory.java
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #290:
URL: https://github.com/apache/directory-scimple/pull/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] jsteelepfpt commented on a diff in pull request #290: Update ObjectMapperFactory.java
Posted by "jsteelepfpt (via GitHub)" <gi...@apache.org>.
jsteelepfpt commented on code in PR #290:
URL: https://github.com/apache/directory-scimple/pull/290#discussion_r1175558371
##########
scim-core/src/main/java/org/apache/directory/scim/core/json/ObjectMapperFactory.java:
##########
@@ -61,6 +61,7 @@ private static ObjectMapper createObjectMapper() {
objectMapper.setAnnotationIntrospector(pair);
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+ objectMapper.configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS, true);
Review Comment:
@bdemers @erant10 This was Eran's suggested fix when I asked him about handling "Add" vs "add" for PATCH operation values. Should probably also add a test for this somewhere, but I just wanted to get this on people's radar screen. Right now, we're getting failures during Azure AD SCIM syncs due to "Add" not being accepted as a valid PATCH operation value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] bdemers commented on pull request #290: Update ObjectMapperFactory.java
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #290:
URL: https://github.com/apache/directory-scimple/pull/290#issuecomment-1520573190
I didn't mean to "resolve" your command, but just to add visibility my response was:
> Great find!
> Given that one major vendor does this, I'm plus one. It's not clear to me what the official RFC stance is, the closest I could find are these:
>
> https://www.rfc-editor.org/rfc/rfc7644#section-3.10
> https://datatracker.ietf.org/doc/html/rfc7643#section-2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org