You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/07/07 06:11:41 UTC
[PR] Make the update_installer_and_pre_commit script more resilient to re matches [airflow]
amoghrajesh opened a new pull request, #52960:
URL: https://github.com/apache/airflow/pull/52960
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
As seen in https://github.com/apache/airflow/actions/runs/16107085605/job/45444460353, the script was supposed to update the version for `UV_VERSION`, but it also accidentally updated `PRE_COMMIT_UV_VERSION` because both names contain `UV_VERSION` and the regex used looked for any text that said `UV_VERSION` and changed the number after it. But it didn’t check if `UV_VERSION` was part of a longer name, like `PRE_COMMIT_UV_VERSION`.
This PR makes the script only look for lines that start with UV_VERSION (not lines like PRE_COMMIT_UV_VERSION).
Simple script to check this behaviour:
```
import re
line = 'PRE_COMMIT_UV_VERSION = "4.1.4"'
# old pattern
old_pattern = re.compile(r'(UV_VERSION = )("[0-9.]+" )?')
# new pattern
new_pattern = re.compile(r'^(\s*UV_VERSION = )("[0-9.]+")', re.MULTILINE)
replacement = r'\1"0.7.19"'
old_result = old_pattern.sub(replacement, line)
new_result = new_pattern.sub(replacement, line)
print("Original: ", line)
print("Old result: ", old_result)
print("New result: ", new_result)
```
Output:
```
Original: PRE_COMMIT_UV_VERSION = "4.1.4"
Old result: PRE_COMMIT_UV_VERSION = "0.7.19"
New result: PRE_COMMIT_UV_VERSION = "4.1.4"
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make the update_installer_and_pre_commit script more resilient to re matches [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #52960:
URL: https://github.com/apache/airflow/pull/52960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make the update_installer_and_pre_commit script more resilient to re matches [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #52960:
URL: https://github.com/apache/airflow/pull/52960#issuecomment-3043623977
### Backport successfully created: v3-0-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/pull/52961"><img src="https://img.shields.io/badge/PR-52961-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make the update_installer_and_pre_commit script more resilient to re matches [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #52960:
URL: https://github.com/apache/airflow/pull/52960#issuecomment-3043638612
He He
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org