You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2011/02/22 22:19:38 UTC

[jira] Created: (THRIFT-1071) SSL/C++: invalid cast breaks build

SSL/C++: invalid cast breaks build
----------------------------------

                 Key: THRIFT-1071
                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
Debian Squeeze
            Reporter: Roger Meier


THRIFT-151 breaks the build on Ubuntu and Debian Squeeze

see https://hudson.apache.org/hudson/job/Thrift/64/console

{code}
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
make[4]: *** [TSSLSocket.lo] Error 1
{code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998105#comment-12998105 ] 

Rowan Kerr edited comment on THRIFT-1071 at 2/23/11 4:10 PM:
-------------------------------------------------------------

There were a couple configure changes from one of the older ssl patches left out of the more recent versions.

Re-running bootstrap.sh and configure did add the correct -lssl flag to LIBS for the cpp Makefile for me on Ubuntu.

      was (Author: rkerr):
    There were a couple configure changes from one of the older ssl patches left out of the more recent versions, but this doesn't seem to add ssl to the libs for the cpp Makefile for me. (Not all that familiar with autotools to be honest).
  
> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1071.
---------------------------------

    Resolution: Fixed
      Assignee: Roger Meier

committed

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>         Attachments: THRIFT-1071_configure.ac_check_ssl.patch, configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998528#comment-12998528 ] 

Rowan Kerr commented on THRIFT-1071:
------------------------------------

bootstrap.sh needs to be re-run after applying the patch

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: THRIFT-1071_configure.ac_check_ssl.patch, configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998094#comment-12998094 ] 

Rowan Kerr edited comment on THRIFT-1071 at 2/22/11 11:21 PM:
--------------------------------------------------------------

Makefile.am needs an update to make sure ssl is linked?

      was (Author: rkerr):
    Makefile.am needs an update to make sure ssl is linked.
  
> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rowan Kerr updated THRIFT-1071:
-------------------------------

    Attachment: pthread_t_cast.patch

Changed to c style cast as per David's suggestion in THRIFT-151.

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rowan Kerr updated THRIFT-1071:
-------------------------------

    Comment: was deleted

(was: Makefile.am needs an update to make sure ssl is linked? Maybe the top-level configure script...)

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998524#comment-12998524 ] 

Rowan Kerr commented on THRIFT-1071:
------------------------------------

That's basically the same as the configure.ac changes I pulled out of the other issue. Checks slightly different ssl headers but I confirmed that it does do the job. (The all-important -lssl is added to lib/cpp/Makefile LIBS).

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: THRIFT-1071_configure.ac_check_ssl.patch, configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998055#comment-12998055 ] 

Roger Meier commented on THRIFT-1071:
-------------------------------------

committed the invalid cast, thanks Rowan!

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998053#comment-12998053 ] 

Roger Meier commented on THRIFT-1071:
-------------------------------------

Rowan, that's fast!

I still have the following build issue:
{code}
make[1]: Entering directory `/home/roger/software/thrift/thrift-trunk/lib/cpp'
/bin/bash ../../libtool --tag=CXX   --mode=link g++ -Wall -g -O2   -o concurrency_test Tests.o libthrift.la -lrt -lpthread
libtool: link: g++ -Wall -g -O2 -o .libs/concurrency_test Tests.o  ./.libs/libthrift.so -lrt -lpthread
./.libs/libthrift.so: undefined reference to `TLSv1_method'
./.libs/libthrift.so: undefined reference to `SSL_connect'
./.libs/libthrift.so: undefined reference to `sk_pop_free'
./.libs/libthrift.so: undefined reference to `BIO_ctrl'
./.libs/libthrift.so: undefined reference to `GENERAL_NAME_free'
./.libs/libthrift.so: undefined reference to `ASN1_STRING_to_UTF8'
./.libs/libthrift.so: undefined reference to `CRYPTO_set_locking_callback'
./.libs/libthrift.so: undefined reference to `ASN1_STRING_length'
./.libs/libthrift.so: undefined reference to `X509_NAME_get_index_by_NID'
./.libs/libthrift.so: undefined reference to `SSL_CTX_set_verify'
./.libs/libthrift.so: undefined reference to `CRYPTO_set_dynlock_destroy_callback'
./.libs/libthrift.so: undefined reference to `sk_value'
./.libs/libthrift.so: undefined reference to `CRYPTO_set_dynlock_lock_callback'
./.libs/libthrift.so: undefined reference to `SSL_load_error_strings'
./.libs/libthrift.so: undefined reference to `SSL_peek'
./.libs/libthrift.so: undefined reference to `CRYPTO_set_dynlock_create_callback'
./.libs/libthrift.so: undefined reference to `RAND_poll'
./.libs/libthrift.so: undefined reference to `SSL_CTX_use_certificate_chain_file'
./.libs/libthrift.so: undefined reference to `SSL_get_peer_certificate'
./.libs/libthrift.so: undefined reference to `X509_get_subject_name'
./.libs/libthrift.so: undefined reference to `SSL_free'
./.libs/libthrift.so: undefined reference to `ERR_clear_error'
./.libs/libthrift.so: undefined reference to `X509_NAME_get_entry'
./.libs/libthrift.so: undefined reference to `SSL_CTX_set_default_passwd_cb_userdata'
./.libs/libthrift.so: undefined reference to `CRYPTO_free'
./.libs/libthrift.so: undefined reference to `X509_get_ext_d2i'
./.libs/libthrift.so: undefined reference to `ERR_free_strings'
./.libs/libthrift.so: undefined reference to `SSL_CTX_new'
./.libs/libthrift.so: undefined reference to `SSL_get_verify_result'
./.libs/libthrift.so: undefined reference to `SSL_read'
./.libs/libthrift.so: undefined reference to `SSL_set_fd'
./.libs/libthrift.so: undefined reference to `EVP_cleanup'
./.libs/libthrift.so: undefined reference to `X509_verify_cert_error_string'
./.libs/libthrift.so: undefined reference to `CRYPTO_num_locks'
./.libs/libthrift.so: undefined reference to `SSL_CTX_load_verify_locations'
./.libs/libthrift.so: undefined reference to `ERR_get_error'
./.libs/libthrift.so: undefined reference to `ERR_reason_error_string'
./.libs/libthrift.so: undefined reference to `SSL_get_wbio'
./.libs/libthrift.so: undefined reference to `sk_num'
./.libs/libthrift.so: undefined reference to `ASN1_STRING_data'
./.libs/libthrift.so: undefined reference to `ERR_peek_error'
./.libs/libthrift.so: undefined reference to `SSL_CTX_use_PrivateKey_file'
./.libs/libthrift.so: undefined reference to `SSL_library_init'
./.libs/libthrift.so: undefined reference to `SSL_CTX_set_default_passwd_cb'
./.libs/libthrift.so: undefined reference to `SSL_get_verify_mode'
./.libs/libthrift.so: undefined reference to `CRYPTO_set_id_callback'
./.libs/libthrift.so: undefined reference to `SSL_CTX_set_cipher_list'
./.libs/libthrift.so: undefined reference to `ERR_remove_state'
./.libs/libthrift.so: undefined reference to `SSL_new'
./.libs/libthrift.so: undefined reference to `SSL_write'
./.libs/libthrift.so: undefined reference to `CRYPTO_cleanup_all_ex_data'
./.libs/libthrift.so: undefined reference to `X509_free'
./.libs/libthrift.so: undefined reference to `SSL_accept'
./.libs/libthrift.so: undefined reference to `SSL_shutdown'
./.libs/libthrift.so: undefined reference to `SSL_get_shutdown'
./.libs/libthrift.so: undefined reference to `SSL_CTX_ctrl'
./.libs/libthrift.so: undefined reference to `X509_NAME_ENTRY_get_data'
./.libs/libthrift.so: undefined reference to `SSL_get_error'
./.libs/libthrift.so: undefined reference to `SSL_CTX_free'
collect2: ld returned 1 exit status
make[1]: *** [concurrency_test] Error 1
make[1]: Leaving directory `/home/roger/software/thrift/thrift-trunk/lib/cpp'
make: *** [all-recursive] Error 1
{code}
I had to pass *-lssl* by hand on Debian squeeze and it works!
{code}
roger@automat:~/software/thrift/thrift-trunk/lib/cpp$ /bin/bash ../../libtool --tag=CXX   --mode=link g++ -Wall -g -O2   -o concurrency_test Tests.o libthrift.la -lrt -lpthread -lssl
libtool: link: g++ -Wall -g -O2 -o .libs/concurrency_test Tests.o  ./.libs/libthrift.so -lrt -lpthread -lssl
roger@slave:~/software/thrift/thrift-trunk/lib/cpp$

roger@automat:~/software/thrift/thrift-trunk/lib/cpp/test$ /bin/bash ../../../libtool --tag=CXX   --mode=link g++ -Wall -g -O2   -o Benchmark Benchmark.o libtestgencpp.la -lrt -lpthread -lssl
libtool: link: g++ -Wall -g -O2 -o .libs/Benchmark Benchmark.o  ./.libs/libtestgencpp.a /home/roger/software/thrift/thrift-trunk/lib/cpp/.libs/libthrift.so -lrt -lpthread -lssl

roger@automat:~/software/thrift/thrift-trunk/lib/cpp/test$
t$ libtool: link: g++ -Wall -g -O2 -o .libs/TFDTransportTest TFDTransportTest.o  ../../../lib/cpp/.libs/libthrift.so -lrt -lpthread -lssl
{code}

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998094#comment-12998094 ] 

Rowan Kerr edited comment on THRIFT-1071 at 2/22/11 11:25 PM:
--------------------------------------------------------------

Makefile.am needs an update to make sure ssl is linked? Maybe the top-level configure script...

      was (Author: rkerr):
    Makefile.am needs an update to make sure ssl is linked?
  
> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998094#comment-12998094 ] 

Rowan Kerr commented on THRIFT-1071:
------------------------------------

Makefile.am needs an update to make sure ssl is linked.

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Rowan Kerr (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rowan Kerr updated THRIFT-1071:
-------------------------------

    Attachment: configure-ssl.patch

There were a couple configure changes from one of the older ssl patches left out of the more recent versions, but this doesn't seem to add ssl to the libs for the cpp Makefile for me. (Not all that familiar with autotools to be honest).

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1071) SSL/C++: invalid cast breaks build

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier updated THRIFT-1071:
--------------------------------

    Attachment: THRIFT-1071_configure.ac_check_ssl.patch

I have added openssl headers and lib to configure.ac => no issues on Debian Squeeze.
Could you verify that patch?

> SSL/C++: invalid cast breaks build
> ----------------------------------
>
>                 Key: THRIFT-1071
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1071
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Ubuntu (Thrift CI Server) https://hudson.apache.org/hudson/job/Thrift
> Debian Squeeze
>            Reporter: Roger Meier
>         Attachments: THRIFT-1071_configure.ac_check_ssl.patch, configure-ssl.patch, pthread_t_cast.patch
>
>
> THRIFT-151 breaks the build on Ubuntu and Debian Squeeze
> see https://hudson.apache.org/hudson/job/Thrift/64/console
> {code}
> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall -g -O2 -MT TSSLSocket.lo -MD -MP -MF .deps/TSSLSocket.Tpo -c src/transport/TSSLSocket.cpp  -fPIC -DPIC -o .libs/TSSLSocket.o
> src/transport/TSSLSocket.cpp: In function 'long unsigned int apache::thrift::transport::callbackThreadID()':
> src/transport/TSSLSocket.cpp:481: error: invalid cast from type 'pthread_t' to type 'long unsigned int'
> make[4]: *** [TSSLSocket.lo] Error 1
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira