You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jean-Louis MONTEIRO <je...@atosorigin.com> on 2009/04/27 14:40:13 UTC
Re: Application exception handling problem
David,
Some months ago, I did some itests to avoid regression.
When I synchronize my working copy with the trunk, I always have those files
changed.
Do you think it would be possible to add itests for that.
Jean-Louis
David Blevins wrote:
>
> Good catch! Went ahead and made that change.
>
> -David
>
> On Sep 25, 2008, at 11:54 AM, Jean-Louis MONTEIRO wrote:
>
>>
>> Hi all,
>>
>> I'm facing a problem with application exceptions handling in OpenEJB
>> (trunk
>> version).
>> Just for information, it worked on previous version (3.0).
>>
>> It's directly link with the point "14.2.1 Application Exception"
>> from the
>> last EJB 3.0 specification.
>> The AnnotationDeployer (from the core module) does not include
>> application
>> exception (with ApplicationException annotation).
>>
>> I think the problem is more or less at line 429 because the test is
>> always
>> false (except when the application exception is declared in the ejb-
>> jar.xml
>> file).
>> Should the test be ?
>> if (assemblyDescriptor.getApplicationException(exceptionClass) ==
>> null) {
>>
>> Kind regards,
>> Jean-Louis
>
--
View this message in context: http://www.nabble.com/Application-exception-handling-problem-tp19673820p23255435.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: Application exception handling problem
Posted by Jean-Louis MONTEIRO <je...@atosorigin.com>.
Done.
No JIRA has been opened so here is the patch file.
http://www.nabble.com/file/p23271111/patch-itests-ApplicationException.txt
patch-itests-ApplicationException.txt
Jean-Louis
David Blevins wrote:
>
>
> On Apr 27, 2009, at 5:40 AM, Jean-Louis MONTEIRO wrote:
>
>>
>> David,
>>
>> Some months ago, I did some itests to avoid regression.
>> When I synchronize my working copy with the trunk, I always have
>> those files
>> changed.
>>
>> Do you think it would be possible to add itests for that.
>
> Sure, if you have a test for it, we'll be happy to add it.
>
> -David
>
>
>>
>>
>>
>> Jean-Louis
>>
>>
>> David Blevins wrote:
>>>
>>> Good catch! Went ahead and made that change.
>>>
>>> -David
>>>
>>> On Sep 25, 2008, at 11:54 AM, Jean-Louis MONTEIRO wrote:
>>>
>>>>
>>>> Hi all,
>>>>
>>>> I'm facing a problem with application exceptions handling in OpenEJB
>>>> (trunk
>>>> version).
>>>> Just for information, it worked on previous version (3.0).
>>>>
>>>> It's directly link with the point "14.2.1 Application Exception"
>>>> from the
>>>> last EJB 3.0 specification.
>>>> The AnnotationDeployer (from the core module) does not include
>>>> application
>>>> exception (with ApplicationException annotation).
>>>>
>>>> I think the problem is more or less at line 429 because the test is
>>>> always
>>>> false (except when the application exception is declared in the ejb-
>>>> jar.xml
>>>> file).
>>>> Should the test be ?
>>>> if (assemblyDescriptor.getApplicationException(exceptionClass) ==
>>>> null) {
>>>>
>>>> Kind regards,
>>>> Jean-Louis
>>>
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Application-exception-handling-problem-tp19673820p23255435.html
>> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>>
>>
>
>
>
--
View this message in context: http://www.nabble.com/Application-exception-handling-problem-tp19673820p23271111.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: Application exception handling problem
Posted by David Blevins <da...@visi.com>.
On Apr 27, 2009, at 5:40 AM, Jean-Louis MONTEIRO wrote:
>
> David,
>
> Some months ago, I did some itests to avoid regression.
> When I synchronize my working copy with the trunk, I always have
> those files
> changed.
>
> Do you think it would be possible to add itests for that.
Sure, if you have a test for it, we'll be happy to add it.
-David
>
>
>
> Jean-Louis
>
>
> David Blevins wrote:
>>
>> Good catch! Went ahead and made that change.
>>
>> -David
>>
>> On Sep 25, 2008, at 11:54 AM, Jean-Louis MONTEIRO wrote:
>>
>>>
>>> Hi all,
>>>
>>> I'm facing a problem with application exceptions handling in OpenEJB
>>> (trunk
>>> version).
>>> Just for information, it worked on previous version (3.0).
>>>
>>> It's directly link with the point "14.2.1 Application Exception"
>>> from the
>>> last EJB 3.0 specification.
>>> The AnnotationDeployer (from the core module) does not include
>>> application
>>> exception (with ApplicationException annotation).
>>>
>>> I think the problem is more or less at line 429 because the test is
>>> always
>>> false (except when the application exception is declared in the ejb-
>>> jar.xml
>>> file).
>>> Should the test be ?
>>> if (assemblyDescriptor.getApplicationException(exceptionClass) ==
>>> null) {
>>>
>>> Kind regards,
>>> Jean-Louis
>>
>
> --
> View this message in context: http://www.nabble.com/Application-exception-handling-problem-tp19673820p23255435.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
>