You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/08 06:24:07 UTC

[GitHub] markusthoemmes commented on a change in pull request #3704: Invoker graceful shutdown and drain mode

markusthoemmes commented on a change in pull request #3704: Invoker graceful shutdown and drain mode
URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193962232
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
 ##########
 @@ -163,6 +171,26 @@ class MessageFeed(description: String,
         goto(FillingPipeline)
       } else stay
 
+    case Event(GracefulShutdown, _) =>
+      goto(GracefulShutdownDrain)
+
+    case _ => stay
+  }
+
+  when(GracefulShutdownDrain) {
+    case Event(Processed, _) =>
+      updateHandlerCapacity()
+      sendOutstandingMessages()
+      stay
+
+    case Event(FillCompleted(messages), _) =>
 
 Review comment:
   Always asynchronous for akka.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services