You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/02 07:14:37 UTC

[GitHub] [shardingsphere] sandynz opened a new issue, #20735: Extract pipeline meta data node change listener SPI for common usage

sandynz opened a new issue, #20735:
URL: https://github.com/apache/shardingsphere/issues/20735

   Part of #19421.
   
   Currently, on wathcing `/pipeline`, event key will be matched by different hard-coded regex, it's not easy to add new node change logic. So it's better to extract pipeline meta data node change listener SPI for common usage.
   
   Related code:
   - PipelineJobExecutor.doStart method
   
   We might need to handle process configuration change for migration job and other types of jobs in the future. And new type job might need to handle other nodes change.
   
   Possible changes:
   - Add pipeline meta data node change listener SPI
   - Add SPI factory
   - Add SPI impl
   - Unit test, etc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #20735: Extract pipeline meta data node change listener SPI for common usage

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20735:
URL: https://github.com/apache/shardingsphere/issues/20735#issuecomment-1235153630

   @azexcy , could you help to follow it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed issue #20735: Extract pipeline meta data node change listener SPI for common usage

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20735: Extract pipeline meta data node change listener SPI for common usage
URL: https://github.com/apache/shardingsphere/issues/20735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] azexcy commented on issue #20735: Extract pipeline meta data node change listener SPI for common usage

Posted by GitBox <gi...@apache.org>.
azexcy commented on issue #20735:
URL: https://github.com/apache/shardingsphere/issues/20735#issuecomment-1235155098

   I will follow it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org